hulk icon indicating copy to clipboard operation
hulk copied to clipboard

question about k-mer frequency

Open XiaomingXu1995 opened this issue 5 years ago • 3 comments

dear will-rowe, HULK is concerned about the k-mer frequency as described in your paper. I find that a minimizer hash value cannot be added into the minimizerSketch when it is contained in the sketch(minimizer.go, line 195). So the hash values in the minimizerSketch are unique. We cannot add the same minimizer hash value into the minimizerSketch inside a window, but if two different windows have the same minimizer-kmer, shall we concern the k-mer frequency?

XiaomingXu1995 avatar Oct 25 '20 02:10 XiaomingXu1995

Hi @XiaomingXu1995 - you are right that only unique minimizers are added to a sketch for a read. It would be a good idea to take into account minimizer frequency, I should probably try that.

I'm afraid HULK has been neglected recently. I will do my best to get back to it and try some new ideas out, including your observation. Thank you for your interest in it.

will-rowe avatar Nov 03 '20 10:11 will-rowe

Any update on this?

Thanks,

Jianshu

jianshu93 avatar Oct 02 '21 04:10 jianshu93

Hi Jianshu,

I'm afraid that I'm pushed for time at the moment and am unlikely to get to this anytime soon.

Will

will-rowe avatar Oct 05 '21 20:10 will-rowe