isaiah icon indicating copy to clipboard operation
isaiah copied to clipboard

[feature] View content of volumes inside isaiah container.

Open shizunge opened this issue 1 year ago • 2 comments

I deploy isaiah via docker. When I try to browser volume in shell I get the following error and cannot proceed.

image

I think if we have mapped the docker volumes from the host to the container of isaish (e.g. /var/lib/docker/volumes:/var/lib/docker/volumes), we should be allowed to view the content of the voluems.

shizunge avatar Sep 27 '24 05:09 shizunge

I learnt that the isaiah image does not contain a shell.

If I build the image based on alpinelinux/docker-cli:latest and do not set DOCKER_RUNNING, I can view the volume.

shizunge avatar Sep 27 '24 07:09 shizunge

Thanks a lot for opening the issue, but most importantly for finding a flow that works.

I am currently looking into it, and running tests just to make sure that everything will be alright when released.

So far, this is how it will work when fully released :

  • The project's Dockerfile will no longer use Scratch, but rather alpinelinux/docker-cli, as you suggested and tried.

  • The DOCKER_RUNNING variable will remain unchanged, as it freezes other on-host-only features.

  • The attachment of a volume to /var/lib/docker/volumes on the container will allow the volume.browse command to bypass the DOCKER_RUNNING check, to enable users to browse their volume via the browser if the volume is attached to Isaiah's container.

  • The image should remain tiny in size thanks to the base image you've suggested.

If you see anything else, please feel free to let me know.

Thanks again!

will-moss avatar Sep 30 '24 20:09 will-moss

Alright.

I was busy lately, but I finally managed to tweak the code, run tests, and ensure that everything works.

I have just published a new release, and you should now be able to browse your volumes even when Isaiah is deployed in a Docker container, provided that you have previously added a mount that is identical to the one you've provided in your first comment (and that's also indicated in the error popup if anyone needs it!).

Hoping that it works better now, and thanks again for opening that issue.

Edit : I finally settled on the Busybox image, but feel free to tell me if there was an advantage with using alpinelinux/docker-cli.

will-moss avatar Oct 18 '24 13:10 will-moss

It does not work on the node where "Agent" is running. (Multi-node mode). The agent hangs somehow.

shizunge avatar Oct 21 '24 20:10 shizunge

Thanks a lot for your feedback.

I had not tested the feature in multi-node mode, it's my bad, my apologies.

I have just fixed the code to accomodate multi-node mode, and it should work now (or at least, it works on my end).

You can pull the latest image.

Sorry again, and looking forward to reading from you!

will-moss avatar Oct 21 '24 21:10 will-moss

Thank you!

shizunge avatar Oct 22 '24 18:10 shizunge