iohook
iohook copied to clipboard
wilix-team
Actively Looking For Maintainers !
Hey everyone,
2020 has been a strange year, and 2021 is starting to look pretty much the same. tbh I don't think I'll have more time to dedicate to iohook. Updates have become really rare, and it is only thanks to this awesome community that we recently added support for modern versions of Node and Electron.
So, that's it, I don't have anymore free time to dedicate to this project, and I don't use it anymore on any personal project, so I'm looking for a motivated maintainer to help with ongoing updates, triage the issues, fix bugs, etc...
I'll stick around, for sure, but we need a new person in charge.
Cheers
:D At this moment we have partially free hands in company. Just need some time for review current state and new PR's. We try write some tests and add some automatisations for creating prebuild's for new Node/Electron versions
Awesome ! We recently switch to node-gyp instead of cmake-js, so yeah the project would need a revamped automated CI (maybe using more recent versions of prebuilt for instance), plus some good tests, you are right :). Let me know if you want to have a quick chat. I'm keeping this issue open a few days to see if anyone wants to join the fun.
:D At this moment we have partially free hands in company. Just need some time for review current state and new PR's. We try write some tests and add some automatizations for creating prebuild's for new Node/Electron versions
@WilixLead, if you are reviewing the current state and updating prebuilds, could you take a look into mac support? There is a long-standing mac issue that is still causing confusion ( see #295 ).
There is a hack that can be implemented (example), but I wonder if it would be possible to update to libuiohook v1.2?
@tcardlab I have an experimental fork adapted to use libuiohook 1.2 here https://github.com/marcelblum/iohook you are welcome to try building from there for Mac to test if it fixes the issue. For me I have never been able to replicate #124 with any release of iohook, and I use iohook on Mac all the time, though only in Electron.
Closing it due inactivity. Please update other issues for their actual state. Now I start clearing repo from old PR's and Issues
@WilixLead I still have issue to make this library work in latest MacOS, did you update libuiohook to 1.2?
@marcelblum #124 seems to be only an issue on node and not electron. I moved iohook from my main process (running electron) to a child process (only node) and saw the exact issue mentioned. Would be interesting to se if libuiohook 1.2 update would fix the issue. @WilixLead
@WilixLead @Djiit Who's the current maintainer of this project? The last time there was any activity from any maintainer is April 19. I and others have to resort to scoped packages and forks to work with this project. If the current maintainer isn't interested anymore please indicate so the project can have a new maintainer as it's an active project.
Hey, as stated before, I can no longer maintain this project. @WilixLead did you pick it up in the end ?
@Djiit Thank you for reopen. I managed to fix only a couple of mistakes, and then time is end :)
@ash0x0 you want to be maintainer?
Would love to. I'm already familiar with the code and I do have the time to invest in this.
Ok. I add you write access. Make iohook great again :)
Thank you, will do my best :)
@Djiit @WilixLead I'll need access to the NPM package, someone add me as collaborator please, same username.
@ash0x0 Please check your email
Thank you, got it.
Also I think the best way to publish npm package - it with CI step
@WilixLead I believe so too. You'll need to add an NPM automation token to the repo secrets under name NODE_AUTH_TOKEN for that to work.
Also, you'll need to disable AppVeyor and travis (if enabled) integration for this repo. AppVeyor is still reporting builds as failed.
@ash0x0 Github actions already done? No need travis and appveyor?
@WilixLead yes, actions is doing releasing now, I've already deleted travis and appveyor configs. Once you add NODE_AUTH_TOKEN secret it'll publish NPM package as well instead of me doing it manually, let me know when you've added it because I can't see secrets.
It's always good to have extra brains! Anyone looking to contribute in any way, maybe to fix a particular bug that's affecting them or add a feature they need, please reach out here and I'll offer the help I can. I'm actively working on making the codebase easier to work with and improving the overall contribution experience.
Hi @ash0x0, I will be happy to help maintain and fix bugs, I will need to know how and whats the best way.
Hi @ash0x0, I will be happy to help maintain and fix bugs, I will need to know how and whats the best way.
That'd be more than welcome. You can check the Todo milestone in issues to see what needs to be fixed. As far as contributing goes, the docs have good info on that. I'd say pick any issue you think you can fix and ping me there and I'll provide help. I see you did some work on #214, maybe you can PR that. You'd need to test on linux and windows, I recommend making use of gh actions and tests. If you can add a unit test action that'd be great for all future PRs too.