angular-relative-date icon indicating copy to clipboard operation
angular-relative-date copied to clipboard

Published 20 hours ago • verified publisher icon wildlyinaccurate

Added years logic

Open KieranDotCo opened this issue 8 years ago • 1 comments

In the current filter there is no logic for working out 'X years ago', I've made a change and modified tests, feel free to close if there is a reason that support for 'X years ago' doesn't exist.

KieranDotCo avatar Nov 10 '16 15:11 KieranDotCo

Hey, thanks for this! I'm all for supporting "X years ago". There's not any particular reason for why it was missing.

There are a bunch of applications that use this filter and I don't want to potentially break their UI, so I'm wondering how we can merge this without negatively affecting existing users of this filter. I guess we could:

  • Do a major version bump to 3.0.0. It's technically correct from a semver point of view but it seems a bit extreme for such a small change.
  • Put this functionality behind a toggle. This keeps backwards compatibility but maybe makes using the filter more clunky than it should be?

What do you think?

wildlyinaccurate avatar Nov 10 '16 17:11 wildlyinaccurate