wildfly-proposals icon indicating copy to clipboard operation
wildfly-proposals copied to clipboard

[WFLY-18526] adds proposal to move BOMs to the Server source repository

Open emmartins opened this issue 1 year ago • 3 comments

Issue: https://issues.redhat.com/browse/WFLY-18526

emmartins avatar Sep 20 '23 10:09 emmartins

I don't recall when this was done, but we originally pulled the BOM out of the WildFly repo. TBH I don't recall the reason either :) I think it was a chicken and egg type of issue for the Quickstarts.

IIRC it was more of a technical issue but we had a very different solution at that time, with static built BOMs.

That said, I was never personally a fan of using the org.wildfly:wildfly-parent POM to import the dependencies. I do understand why we did that though.

The WildFly BOMs now uses the - fairly recent - internal BOMs to obtain the dep management but it is not much diference TBH, but what we are doing is totally different than in the past, we now have BOM Builders instead, which use the maven plugin taking advantage of the whole dep management "context", to restore the transitive relationships lost with the "excludes".

I'm personally not opposed to moving the BOM back into the main WildFly repository. However, I think we need to take care when we do it. I don't think we really need to preserve the history, but that's just my opinion.

FYI the feature PR is merged already.

emmartins avatar Oct 11 '23 21:10 emmartins

Oh, should this be merged then?

jamezp avatar Oct 11 '23 22:10 jamezp

Let's keep it open till feature team approves it, if changes or enhancements are needed we can add another feature PR. Downstream this only targets 8.1 so let's give time everyone some time to digest it.

emmartins avatar Oct 11 '23 22:10 emmartins

Time enough to digest. :) Time to merge.

bstansberry avatar Jul 02 '24 22:07 bstansberry