wildfly-proposals
wildfly-proposals copied to clipboard
wildfly
[WFCORE-4807] Add option to route log messages based on the current thread's class loader
Maybe this should be opt-in rather than opt-out by default. I don't have a strong opinion either way. I went with opt-out as it seems like users have been wanting some kind of filter or way to mimic this behavior for some time. This should act like the old TCCL filter as far as I understand how that filter worked.
Hello James, I'm looking to the description of the RFE jira, linked jiras, RFE analysis and EAP documentation and I'm still not sure about a few technical information which prevents me to fully understand this analysis:
- What is LogContext, what is its purpose? Is there some relationship between LogContext and Logging profile? This class is not described in product doc and javadoc seems to be poor.
- Can you please describe some details (in the analysis) about routing of messages to LogContext objects? Or provide a link to the documentation where this is described?
- LOGMGR-264 description contains some information about switching LogContext for a logger. Can you please elaborate on this topic in the analysis?
- LOGMGR-264 has MR against 2.2 branch. Why not to use 2.3 or master branch for EAP8 RFE?
Hello James, I'm looking to the description of the RFE jira, linked jiras, RFE analysis and EAP documentation and I'm still not sure about a few technical information which prevents me to fully understand this analysis:
- What is LogContext, what is its purpose? Is there some relationship between LogContext and Logging profile? This class is not described in product doc and javadoc seems to be poor.
I'll try to think of a better way to describe this. Essentially though a LogContext is a context associated with a logging configuration. A logging profile does use it's own LogContext as does any per-deployment logging.
- Can you please describe some details (in the analysis) about routing of messages to LogContext objects? Or provide a link to the documentation where this is described?
I'll see what I can do here. Would an example help?
- LOGMGR-264 description contains some information about switching LogContext for a logger. Can you please elaborate on this topic in the analysis?
For LOGMGR-264 I guess it's more of an API that WildFly can use to switch the context. WildFly is going to do it based on the class loader, TCCL.
- LOGMGR-264 has MR against 2.2 branch. Why not to use 2.3 or master branch for EAP8 RFE?
The log manager is in an odd state ATM. The master branch was heavily refactored for Quarkus. However, Quarkus uses a fork so master is kind of "dead" in a sense.
For 2.3 that is basically the same as 2.2 except for the JsonFormatter it uses the jakarta.* namespace changes.
Really this might all change. What I'm considering is just deleting master and making 2.3 main and deleting 2.3. Then making 2.2 the next iteration for WildFly and main will be used once we do the Jakarta name space changes in WildFly.
The test branch is currently https://github.com/jamezp/wildfly/tree/WFCORE-4807-tests.
Can you please explicitly mention in the analysis what will be the default value of allow-log-routing attribute? I see two resolved threads about this topic, but I still don't see this info mentioned in the analysis:
- https://github.com/wildfly/wildfly-proposals/pull/281#discussion_r695561754
- https://github.com/wildfly/wildfly-proposals/pull/281#discussion_r745565981
Can you please explicitly mention in the analysis what will be the default value of
allow-log-routingattribute? I see two resolved threads about this topic, but I still don't see this info mentioned in the analysis:
Sorry about that @marekkopecky. I meant to do that when I resolved those comments and got side-tracked. It's fixed now.