wildfly-operator icon indicating copy to clipboard operation
wildfly-operator copied to clipboard

Addressed issue #100 and EAP7-1394

Open jmfinelli opened this issue 2 years ago • 7 comments

This PR addresses #100 and EAP7-1394.

jmfinelli avatar Oct 16 '23 20:10 jmfinelli

Hi @yersan, could you please help me with this? I'm not sure why the GitHub Action is failing...apparently, it requires golang 1.19 but, for some reason, the Action runs golang 1.17 :confused:

jmfinelli avatar Oct 18 '23 13:10 jmfinelli

Hi @jmfinelli , it should be fixed with https://github.com/wildfly/wildfly-operator/pull/279

yersan avatar Oct 20 '23 09:10 yersan

Hi @jmfinelli , it should be fixed with #279

Thanks @yersan, I will re-run all checks for this PR :-)

jmfinelli avatar Oct 20 '23 11:10 jmfinelli

Hello @jmfinelli , FYI, we have updated the libraries and SDK and adjusted some loggers under the tx tests. This has generated some conflicts with your PR.

yersan avatar Oct 30 '23 17:10 yersan

Hello @jmfinelli , FYI, we have updated the libraries and SDK and adjusted some loggers under the tx tests. This has generated some conflicts with your PR.

Thanks for your message @yersan. Strangely enough, I just rebased my branch on top of main and I didn't get any conflict :confused: Let's see what errors the CI will report

UPDATE: Saw the conflict...and fixed it. Thanks @yersan

jmfinelli avatar Nov 02 '23 13:11 jmfinelli

@jmfinelli Could you rebase this one on top of the latest main? thanks!

yersan avatar Feb 27 '24 16:02 yersan

@jmfinelli CRD and generated openapi are out of sync with your changes. You have to sync them, for example, using make build before pushing up the PR

make build executed and PR updated. Thanks @yersan!

jmfinelli avatar Mar 07 '24 09:03 jmfinelli

Thanks @jmfinelli

yersan avatar May 29 '24 08:05 yersan