wildfly-core icon indicating copy to clipboard operation
wildfly-core copied to clipboard

WFCORE-6995 Allow stability-specific resource transformations for mixed domains

Open pferraro opened this issue 1 year ago • 9 comments

https://issues.redhat.com/browse/WFCORE-6995

~~Submitting as a draft while I collect feedback and add tests.~~

@yersan Until https://github.com/wildfly/wildfly-legacy-test publishes releases for WildFly versions, it will be impossible to create model transformation tests for COMMUNITY stability.

pferraro avatar Oct 11 '24 13:10 pferraro

Core -> WildFly Preview Integration Build 14065 outcome was FAILURE using a merge of e05436baa4a0649708bba252cc05f2a61cb4d94f Summary: Tests failed: 1 (1 new), passed: 5007, ignored: 59 Build time: 02:57:01

Failed tests

TestSuite: org.eclipse.microprofile.rest.client.tck.sse.ReactiveStreamsPublisherTckTest.stochastic_spec103_mustSignalOnMethodsSequentially: java.lang.NullPointerException: Cannot invoke "org.reactivestreams.Publisher.subscribe(org.reactivestreams.Subscriber)" because "pub" is null
	at org.reactivestreams.tck.PublisherVerification$5$1.run(PublisherVerification.java:257)
	at org.reactivestreams.tck.PublisherVerification.activePublisherTest(PublisherVerification.java:1135)
	at org.reactivestreams.tck.PublisherVerification$5.apply(PublisherVerification.java:251)
	at org.reactivestreams.tck.PublisherVerification$5.apply(PublisherVerification.java:248)
	at org.reactivestreams.tck.PublisherVerification.stochasticTest(PublisherVerification.java:1204)
	at org.reactivestreams.tck.PublisherVerification.stochastic_spec103_mustSignalOnMethodsSequentially(PublisherVerification.java:248)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:141)
	at org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:686)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:230)
	at org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:63)
	at org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:992)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethods(TestInvoker.java:203)
	at org.testng.internal.invokers.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:154)
	at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:134)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.testng.TestRunner.privateRun(TestRunner.java:739)
	at org.testng.TestRunner.run(TestRunner.java:614)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:421)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:413)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:373)
	at org.testng.SuiteRunner.run(SuiteRunner.java:312)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:95)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1274)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1208)
	at org.testng.TestNG.runSuites(TestNG.java:1112)
	at org.testng.TestNG.run(TestNG.java:1079)
------- Stderr: -------
java.lang.AssertionError: Mock Sse Server did not start as expected expected [true] but found [false]
	at org.testng.Assert.fail(Assert.java:111)
	at org.testng.Assert.failNotEquals(Assert.java:1578)
	at org.testng.Assert.assertTrue(Assert.java:57)
	at org.eclipse.microprofile.rest.client.tck.sse.AbstractSseTest.launchServer(AbstractSseTest.java:62)
	at org.eclipse.microprofile.rest.client.tck.sse.ReactiveStreamsPublisherTckTest.createPublisher(ReactiveStreamsPublisherTckTest.java:106)
	at org.reactivestreams.tck.PublisherVerification.activePublisherTest(PublisherVerification.java:1134)
	at org.reactivestreams.tck.PublisherVerification$5.apply(PublisherVerification.java:251)
	at org.reactivestreams.tck.PublisherVerification$5.apply(PublisherVerification.java:248)
	at org.reactivestreams.tck.PublisherVerification.stochasticTest(PublisherVerification.java:1204)
	at org.reactivestreams.tck.PublisherVerification.stochastic_spec103_mustSignalOnMethodsSequentially(PublisherVerification.java:248)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:141)
	at org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:686)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:230)
	at org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:63)
	at org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:992)


wildfly-ci avatar Oct 17 '24 20:10 wildfly-ci

Core -> WildFly Preview Integration Build 14066 outcome was FAILURE using a merge of e05436baa4a0649708bba252cc05f2a61cb4d94f Summary: Tests passed: 5009, ignored: 58; exit code 1 (Step: Build & test full (Maven)) Build time: 02:48:20

wildfly-ci avatar Oct 17 '24 22:10 wildfly-ci

Core -> WildFly Preview Integration Build 14067 outcome was FAILURE using a merge of e05436baa4a0649708bba252cc05f2a61cb4d94f Summary: Exit code 1 (Step: Build & test full (Maven)) Build time: 00:05:30

wildfly-ci avatar Oct 18 '24 14:10 wildfly-ci

Core -> WildFly Preview Integration Build 14068 outcome was FAILURE using a merge of e05436baa4a0649708bba252cc05f2a61cb4d94f Summary: Tests failed: 1 (1 new), passed: 5002, ignored: 84 Build time: 03:01:04

Failed tests

org.wildfly.test.integration.microprofile.jwt.propagation.JWTIdentityPropagationTestCase(layers-test).testInvokeEJBWithinSingleDeploymentOutflowNotPossibleTrustNotConfigured: java.lang.AssertionError: expectedMessage:[targetCallerPrincipal: anonymous, targetIsCallerAdmin: false] returned msg:[hello + testUser, hasJWT: true, targetCallerPrincipal: testUser, targetIsCallerAdmin: false]
	at org.wildfly.test.integration.microprofile.jwt.propagation.JWTIdentityPropagationTestCase.testInvokeEJB(JWTIdentityPropagationTestCase.java:335)
	at org.wildfly.test.integration.microprofile.jwt.propagation.JWTIdentityPropagationTestCase.testInvokeEJBWithinSingleDeploymentOutflowNotPossibleTrustNotConfigured(JWTIdentityPropagationTestCase.java:255)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)


wildfly-ci avatar Oct 21 '24 11:10 wildfly-ci

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

github-actions[bot] avatar Dec 15 '24 01:12 github-actions[bot]

Core -> Full Integration Build 14427 outcome was UNKNOWN using a merge of c997c156467c4eaf884202e8771c6c5c30fde3d7 Summary: Canceled (Error while applying patch; cannot find commit c7edee258486bbd6030065031f43a0b444136770 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6214/merge branch was updated and the commit selected for the ... Build time: 00:00:34

wildfly-ci avatar Dec 16 '24 12:12 wildfly-ci

Core -> Full Integration Build 14126 outcome was UNKNOWN using a merge of c997c156467c4eaf884202e8771c6c5c30fde3d7 Summary: Canceled (Error while applying patch; cannot find commit c7edee258486bbd6030065031f43a0b444136770 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6214/merge branch was updated and the commit selected for the ... Build time: 00:00:15

wildfly-ci avatar Dec 16 '24 12:12 wildfly-ci

Core -> WildFly Preview Integration Build 14208 outcome was UNKNOWN using a merge of c997c156467c4eaf884202e8771c6c5c30fde3d7 Summary: Canceled (Error while applying patch; cannot find commit c7edee258486bbd6030065031f43a0b444136770 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/6214/merge branch was updated and the commit selected for the ... Build time: 00:00:15

wildfly-ci avatar Dec 16 '24 12:12 wildfly-ci

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

github-actions[bot] avatar Feb 01 '25 00:02 github-actions[bot]

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

github-actions[bot] avatar Apr 01 '25 01:04 github-actions[bot]

Bump (to prevent github autoclose)

pferraro avatar Apr 02 '25 17:04 pferraro

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

github-actions[bot] avatar May 18 '25 01:05 github-actions[bot]

Bump (to prevent github autoclose). @bstansberry Are we still interested in this? If so, can you take a look?

pferraro avatar May 22 '25 08:05 pferraro

@pferraro I had a look and made comments. I think Yeray's earlier are the more critical ones.

Re whether we are interested in this, TBH I'm relying on you and @yersan to tell me. I think we are because in all the discussions about it we keep working on it and I think we'd stop if we decided not to do it. ;) But the details of the back-and-forth are flushed from memory, partly because I'm relying on you guys.

This is something good to have, since it will allow us to test community-community paired stability levels in mixed domains. I don't see it as something urgent to do; I have never read issues with mixed domains on the community side, so, probably something that is not widely used. It brings up more maintenance, and the fix indeed looks complex. However, having those tests in practice is good and necessary. It will also help later to future promotions by moving a feature from community stability to a higher one.

@pferraro I don't know how complex this would end up at the end, not only on the solution but also on the future maintenance, so if you still have doubts whether this is necessary, I would be fine because I don't think this scenario is widely used in upstream.

yersan avatar May 28 '25 11:05 yersan

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

github-actions[bot] avatar Jul 13 '25 01:07 github-actions[bot]

Bump to keep alive.

pferraro avatar Jul 13 '25 09:07 pferraro

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

github-actions[bot] avatar Aug 29 '25 00:08 github-actions[bot]

Bump to keep alive.

pferraro avatar Aug 29 '25 09:08 pferraro

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

github-actions[bot] avatar Oct 14 '25 00:10 github-actions[bot]