wildfly-core icon indicating copy to clipboard operation
wildfly-core copied to clipboard

[WFCORE-5691][Preview] Allow setting timeout for token introspection

Open lvydra opened this issue 1 year ago • 14 comments

https://issues.redhat.com/browse/EAP7-1856 https://issues.redhat.com/browse/WFCORE-5691 https://issues.redhat.com/browse/ELY-2189

lvydra avatar Jun 11 '24 14:06 lvydra

Not sure if this would be a necessary fix that would prevent merging this, but in general model and schema bumps go in an independent commit, and on top of that one, any system change. This is up to the Elytron component leads. CC @fjuma

yersan avatar Jun 18 '24 09:06 yersan

@lvydra There is nothing written, but for nondefault stability level, we generally append the stability level at the PR title, e.g "[WFCORE-XYZ][Community] ...."

yersan avatar Jun 18 '24 09:06 yersan

This is likely to conflict with https://github.com/wildfly/wildfly-core/pull/5999

yersan avatar Jun 18 '24 10:06 yersan

Not sure if this would be a necessary fix that would prevent merging this, but in general model and schema bumps go in an independent commit, and on top of that one, any system change. This is up to the Elytron component leads. CC @fjuma

Yes, model and schema bumps should be part of a separate commit and should also have a separate WFCORE issue associated with it. Please coordinate with @PrarthonaPaul since both of you will need this.

fjuma avatar Jun 18 '24 14:06 fjuma

Not sure if this would be a necessary fix that would prevent merging this, but in general model and schema bumps go in an independent commit, and on top of that one, any system change. This is up to the Elytron component leads. CC @fjuma

Yes, model and schema bumps should be part of a separate commit and should also have a separate WFCORE issue associated with it. Please coordinate with @PrarthonaPaul since both of you will need this.

Here is the commit for the subsystem bump for elytron from community:18.0 to preview:18.0 : https://github.com/wildfly/wildfly-core/pull/5999/commits/53656645a4b85ada6ca6e0037e3a481abecfb0aa

@lvydra You can cherry-pick that to your PR and add your RFE changes on top.

PrarthonaPaul avatar Jul 03 '24 16:07 PrarthonaPaul

Just one small change on the comment from @PrarthonaPaul - @lvydra please rebase your changes on top of that commit so you both preserve the same SHA - where we use a common commit we are trying to ensure it happens only once.

darranl avatar Jul 10 '24 15:07 darranl

Also the Jira issue and this PR seem to be referencing the Community stability level but the code seems to be targeting Preview.

I would suggest we continue with Preview as we can then promote to Community or Default in a later step.

darranl avatar Jul 10 '24 15:07 darranl

Thanks @PrarthonaPaul, I have rebased my changes on top of your subsystem bump commit.

lvydra avatar Jul 15 '24 07:07 lvydra

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

github-actions[bot] avatar Aug 30 '24 00:08 github-actions[bot]

/retest

bstansberry avatar Sep 17 '24 15:09 bstansberry

Core -> Full Integration Build 13903 outcome was FAILURE using a merge of d07f14e29147abb6bf206c4fbfd6ed4ea06df1b7 Summary: Tests failed: 1 (1 new), passed: 3989, ignored: 59 Build time: 02:22:31

Failed tests

org.jboss.as.test.clustering.cluster.ejb.timer.DistributedTimerServiceTestCase.test: java.lang.AssertionError: class org.jboss.as.test.clustering.cluster.ejb.timer.beans.AutoPersistentTimerBean={node-1=[]}. Actual: 0
	at org.jboss.as.test.clustering.cluster.ejb.timer.AbstractTimerServiceTestCase.test(AbstractTimerServiceTestCase.java:305)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor27.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor26.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor25.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor15.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
------- Stdout: -------
node-2 2024-09-17 17:34:09,394 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.5.Final
node-2 2024-09-17 17:34:09,883 INFO  [org.jboss.msc] (main) JBoss MSC version 1.5.5.Final
node-2 2024-09-17 17:34:09,892 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final
node-2 2024-09-17 17:34:10,000 INFO  [org.jboss.as] (MSC service thread 1-3) WFLYSRV0049: WildFly 34.0.0.Beta1-SNAPSHOT (WildFly Core 26.0.0.Beta5-SNAPSHOT) starting
node-2 2024-09-17 17:34:11,262 INFO  [org.wildfly.security] (Controller Boot Thread) ELY00001: WildFly Elytron version 2.5.2.Final
node-2 2024-09-17 17:34:12,138 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
node-2 2024-09-17 17:34:12,163 INFO  [org.xnio] (MSC service thread 1-6) XNIO version 3.8.16.Final
node-2 2024-09-17 17:34:12,172 INFO  [org.xnio.nio] (MSC service thread 1-6) XNIO NIO Implementation Version 3.8.16.Final
node-2 2024-09-17 17:34:12,210 WARN  [org.jboss.as.txn] (ServerService Thread Pool -- 53) WFLYTX0013: The node-identifier attribute on the /subsystem=transactions is set to the default value. This is a danger for environments running multiple servers. Please make sure the attribute value is unique.
node-2 2024-09-17 17:34:12,275 INFO  [org.jboss.as.connector.subsystems.datasources] (ServerService Thread Pool -- 32) WFLYJCA0004: Deploying JDBC-compliant driver class org.h2.Driver (version 2.2)
node-2 2024-09-17 17:34:12,298 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 40) WFLYCLINF0001: Activating Infinispan subsystem.
node-2 2024-09-17 17:34:12,307 INFO  [org.jboss.as.jaxrs] (ServerService Thread Pool -- 42) WFLYRS0016: RESTEasy version 6.2.10.Final
node-2 2024-09-17 17:34:12,314 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-2) WFLYUT0003: Undertow 2.3.17.Final starting
node-2 2024-09-17 17:34:12,347 INFO  [org.jboss.remoting] (MSC service thread 1-1) JBoss Remoting version 5.0.29.Final
node-2 2024-09-17 17:34:12,432 INFO  [org.jboss.as.naming] (ServerService Thread Pool -- 48) WFLYNAM0001: Activating Naming Subsystem
node-2 2024-09-17 17:34:12,435 INFO  [org.wildfly.extension.io] (ServerService Thread Pool -- 41) WFLYIO001: Worker 'default' has auto-configured to 8 IO threads with 64 max task threads based on your 4 available processors
node-2 2024-09-17 17:34:12,483 INFO  [org.jboss.as.naming] (MSC service thread 1-4) WFLYNAM0003: Starting Naming Service
node-2 2024-09-17 17:34:12,462 INFO  [org.jboss.as.connector] (MSC service thread 1-3) WFLYJCA0009: Starting Jakarta Connectors Subsystem (WildFly/IronJacamar 3.0.10.Final)
node-2 2024-09-17 17:34:12,457 INFO  [org.jboss.as.connector.deployers.jdbc] (MSC service thread 1-2) WFLYJCA0018: Started Driver service with driver-name = h2
node-2 2024-09-17 17:34:12,526 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 44) WFLYCLJG0001: Activating JGroups subsystem. JGroups version 5.2.27
node-2 2024-09-17 17:34:12,708 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-7) WFLYUT0012: Started server default-server.
node-2 2024-09-17 17:34:12,720 WARN  [org.wildfly.extension.elytron] (MSC service thread 1-2) WFLYELY00023: KeyStore file '/opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/clustering/target/wildfly-clustering-ejb-2/standalone/configuration/application.keystore' does not exist. Used blank.
node-2 2024-09-17 17:34:12,743 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-6) Queuing requests.


wildfly-ci avatar Sep 17 '24 17:09 wildfly-ci

@pferraro Does this look ok now?

bstansberry avatar Sep 17 '24 20:09 bstansberry

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

github-actions[bot] avatar Nov 02 '24 00:11 github-actions[bot]

There has been no activity on this PR for 90 days and it has been closed automatically.

github-actions[bot] avatar Jan 31 '25 00:01 github-actions[bot]

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

github-actions[bot] avatar Mar 18 '25 00:03 github-actions[bot]

There has been no activity on this PR for 90 days and it has been closed automatically.

github-actions[bot] avatar Jun 16 '25 01:06 github-actions[bot]