wildfly-core icon indicating copy to clipboard operation
wildfly-core copied to clipboard

[WFCORE-6661] More accurate, resettable start time calculation

Open bstansberry opened this issue 1 year ago • 5 comments

https://issues.redhat.com/browse/WFCORE-6661

This encapsulates the existing and possible future (WFCORE-6657) behavior around calculating and resetting 'start time' in a class, instead of passing around primitive 'startTime' longs and doing math. It uses RuntimeMXBean for the original 'start time' of a non-embedded process, instead of using Module.getStartTime(), which is a time when JBoss Modules started, not when the JVM did.

bstansberry avatar Jan 10 '24 02:01 bstansberry

Hello @bstansberry are you interested in getting this for WF23?

yersan avatar Jan 12 '24 09:01 yersan

@yersan Thanks for asking. No, this not urgent and shouldn't go in WF 31. It's a small foundation piece that's important for my prototyping at https://github.com/bstansberry/wildfly-core/commits/WildFly_CRaC, but that is just a research project. It's valid on it's own (it uses a more accurate JVM start time) so I went ahead and sent up the PR, but that benefit is quite minor and is not enough to justify doing it so late in the 31 work.

bstansberry avatar Jan 15 '24 19:01 bstansberry

Core -> Full Integration Build 13423 outcome was UNKNOWN using a merge of 30d15284993c9913e41a330c4405e11589b899cd Summary: Canceled (Tests passed: 7515, ignored: 101; exit code 143 (Step: Build & test full (Maven)) (new)) Build time: 03:36:38

wildfly-ci avatar Jan 20 '24 03:01 wildfly-ci

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

github-actions[bot] avatar Mar 26 '24 00:03 github-actions[bot]

Core -> Full Integration Build 13418 outcome was FAILURE using a merge of a7d464b0e8a818e8a95924d2ce51a25724b83ff5 Summary: Tests failed: 1 (1 new), passed: 4036, ignored: 51 Build time: 03:32:13

Failed tests

org.jboss.as.test.clustering.cluster.ejb.stateful.StatefulTimeoutTestCase.timeout: java.lang.AssertionError: expected:<4> but was:<0>
	at org.jboss.as.test.clustering.cluster.ejb.stateful.StatefulTimeoutTestCase.timeout(StatefulTimeoutTestCase.java:88)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
------- Stdout: -------
 [0m03:19:36,713 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.4.Final
 [0m [0m03:19:38,061 INFO  [org.jboss.msc] (main) JBoss MSC version 1.5.3.Final
 [0m [0m03:19:38,077 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final
 [0m [0m03:19:38,324 INFO  [org.jboss.as] (MSC service thread 1-1) WFLYSRV0049: WildFly Full 32.0.0.Beta1-SNAPSHOT (WildFly Core 24.0.0.Beta4-SNAPSHOT) starting
 [0m [0m03:19:41,324 INFO  [org.wildfly.security] (Controller Boot Thread) ELY00001: WildFly Elytron version 2.4.0.CR1
 [0m [0m03:19:42,680 INFO  [org.jboss.as.controller.management-deprecated] (ServerService Thread Pool -- 5) WFLYCTL0028: Attribute 'cluster' in the resource at address '/subsystem=ejb3/service=remote' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
 [0m [0m03:19:42,962 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
 [0m [0m03:19:43,001 INFO  [org.xnio] (MSC service thread 1-2) XNIO version 3.8.13.Final
 [0m [0m03:19:43,011 INFO  [org.xnio.nio] (MSC service thread 1-2) XNIO NIO Implementation Version 3.8.13.Final
 [0m [0m03:19:43,220 INFO  [org.jboss.remoting] (MSC service thread 1-2) JBoss Remoting version 5.0.28.Final
 [0m [0m03:19:43,200 INFO  [org.jboss.as.jaxrs] (ServerService Thread Pool -- 42) WFLYRS0016: RESTEasy version 6.2.8.Final
 [0m [33m03:19:43,225 WARN  [org.jboss.as.txn] (ServerService Thread Pool -- 53) WFLYTX0013: The node-identifier attribute on the /subsystem=transactions is set to the default value. This is a danger for environments running multiple servers. Please make sure the attribute value is unique.


wildfly-ci avatar Mar 29 '24 04:03 wildfly-ci

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

github-actions[bot] avatar May 17 '24 00:05 github-actions[bot]

Core -> Full Integration Build 13884 outcome was FAILURE using a merge of 1acec9db132e532358918aa7fbc0dab574c9ad1f Summary: Compilation error: Compiler (new) Build time: 00:01:03

wildfly-ci avatar Jun 19 '24 08:06 wildfly-ci

Core -> WildFly Preview Integration Build 13680 outcome was FAILURE using a merge of 1acec9db132e532358918aa7fbc0dab574c9ad1f Summary: Compilation error: Compiler (new) Build time: 00:01:05

wildfly-ci avatar Jun 19 '24 08:06 wildfly-ci

Core -> Full Integration Build 13609 outcome was FAILURE using a merge of 1acec9db132e532358918aa7fbc0dab574c9ad1f Summary: Compilation error: Compiler (new) Build time: 00:01:06

wildfly-ci avatar Jun 19 '24 08:06 wildfly-ci

Upss, I made a mistake by resolving the conflicts directly.

yersan avatar Jun 20 '24 07:06 yersan

Core -> Full Integration Build 13885 outcome was FAILURE using a merge of 6b05c02c2c7e6e35a313217606e43cab86e5717d Summary: Compilation error: Compiler (new) Build time: 00:00:43

wildfly-ci avatar Jun 20 '24 07:06 wildfly-ci

Core -> WildFly Preview Integration Build 13681 outcome was FAILURE using a merge of 6b05c02c2c7e6e35a313217606e43cab86e5717d Summary: Compilation error: Compiler (new) Build time: 00:00:49

wildfly-ci avatar Jun 20 '24 07:06 wildfly-ci

Core -> Full Integration Build 13610 outcome was FAILURE using a merge of 6b05c02c2c7e6e35a313217606e43cab86e5717d Summary: Compilation error: Compiler (new) Build time: 00:00:53

wildfly-ci avatar Jun 20 '24 07:06 wildfly-ci

@yersan I rebased.

bstansberry avatar Jun 25 '24 17:06 bstansberry

Thanks @bstansberry

yersan avatar Jul 08 '24 09:07 yersan