wildfly-core [WFCORE-5679] Generate and export operation

https://issues.redhat.com/browse/WFCORE-5679

Apr 25 '22 11:04 lvydra

@darranl Just wanted to check with you since you had created WFCORE-5679 - this issue is about introducing new runtime operations for the credential-store resource. Although it doesn't affect subsystem configuration itself, it does affect documentation. Should we create an RFE to track this?

Apr 25 '22 18:04 fjuma

I think lets get all the pieces together for this first and reassess if we want an RFE. IMO this probably could be an enhancement rather than a full feature.

We should double check we have sufficient tests and we will also need a PR to WildFly for the community documentation.

Apr 27 '22 13:04 darranl

@lvydra Thanks for working on this! I've added some comments. Feel free to let me know if you have any questions.

Apr 27 '22 16:04 fjuma

Hi @fjuma Thanks for the review, I have updated PR and added some comments.

May 04 '22 12:05 lvydra

Core - Full Integration Build 11408 outcome was FAILURE using a merge of 2028ab376c8841ed4a85252f95fa197708da4c3b Summary: Tests failed: 1 (1 new), passed: 3989, ignored: 41 Build time: 01:54:07

Failed tests

org.jboss.as.test.integration.messaging.jms.external.prefix.ExternalJMSDestinationDefinitionMessagingDeploymentTestCase.testSendMessage: java.io.IOException: java.util.concurrent.ExecutionException: java.io.IOException: HTTP Status 500 Response: <html><head><title>ERROR</title><style>
body {
    font-family: "Lucida Grande", "Lucida Sans Unicode", "Trebuchet MS", Helvetica, Arial, Verdana, sans-serif;
    margin: 5px;
}

.header {
    background-image: linear-gradient(bottom, rgb(153,151,153) 8%, rgb(199,199,199) 54%);
    background-image: -o-linear-gradient(bottom, rgb(153,151,153) 8%, rgb(199,199,199) 54%);
    background-image: -moz-linear-gradient(bottom, rgb(153,151,153) 8%, rgb(199,199,199) 54%);
    background-image: -webkit-linear-gradient(bottom, rgb(153,151,153) 8%, rgb(199,199,199) 54%);
    background-image: -ms-linear-gradient(bottom, rgb(153,151,153) 8%, rgb(199,199,199) 54%);
    
    background-image: -webkit-gradient(
        linear,
        left bottom,
        left top,
        color-stop(0.08, rgb(153,151,153)),
        color-stop(0.54, rgb(199,199,199))
    );
    color: black;
    padding: 2px;
    font-weight: normal;
    border: solid 1px;
    font-size: 170%;
    text-align: left;
    vertical-align: middle; 
    height: 32px; 
    margin-bottom: 10px;
}
.error-div {
    display: inline-block;
    width: 32px;
    height: 32px;
    background: url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAABmJLR0QAAAAAAAD5Q7t/AAAACXBIWXMAAABIAAAASABGyWs+AAAACXZwQWcAAAAgAAAAIACH+pydAAAGGElEQVRYw8WXW2wcVxnHf+fM7NXrdXbdtZ3ipGqCEzvQKmlFoUggwkvvGBoaqVVV5Y0nkCoQPPCAhMQbQlzUh/IWHoh6QUVKZVLxUCGogKZRW9uJkyg0iVzZ2dhre9c7u7M7c87hYWc2M7t2bBASI306O/85+v7/7zLn24H/8yV2u/EcFNvwVNK2X0DKw1qpYaX1gCWlY0m5arRe8JQ6I2DmaVj/nwk4CxO2Zf1aw9dKo6N67+eOZHN7x0gViiSHBmlXa7hrazjLt1i+eKmxUi5bwpg/e8a8PA3X/msBr0MyJ+WvgFOffehY8v7HH5OW78HqGjgOtNrge2AnIJWAgQEYLqBsm3/NvKM/mZ1rYczpRa2/9x3w/iMBM1BCiHfuGRmZevClF9NJ5cP1m9B0+/aa3t/ZDNw3TtuSfPy737trK6sXtTGPPwOruxLwNhSEEHMHpqZGDz93wubKFdio3ZXUGNOHs2cIDh/g6pt/9G8uXLnlGPP5k1Dt5bN60m6lhXj34OTkxKET37SZm4d6oz/KgFRH7yOrBozbwlTWGf7ql6RZrWTcytrxaTj9Ro9OGb3JS/mz0nDxgYnnvmWbuUsdJ6FTY2JmImShqZA83N90UbOXOXDiG4nCcPFoTsqfbluCP8DenJQLx1/+7pBcXILaZl9qo2svFmalb48xkM9hxkf5+29+u9HSenIayn0ZyEr5i0NHpnKy7aGrtW6UehsLozRBRlRQEh3BwzLpWh3h++yfPJRLSvnzvhK8DkPamOl7n3nCUjcXtyXuK0X0WViaAFc9QtSNJe594uu2MubZGcjHBGTgqeFiQQml0K12nDgSpd4iyi4uRMci6Q8xJSWq7SGEZCg/qD14LCYgIcTzoxMHc6qygYk40aETKTFSdh2aANOWhbEsjJSYCK6C/V0LcH+9xvCB/TlbiBdCAXbQMJPZ/fvQjUbXEULAa6/1deyuh0dwNU+e7DSzEOhmi8xn9iI+ujgVE6ChlBwpYcqVjuIgA3IXBMYYtNbd30IIpJQI0ZEa+gPQnk9ieA8GSrESaGNyiWIBrVQntUHqdrq01iiluo0WilBK4fs+WutOr4S9YAyJoRzamMGYAClEve046ETyTr13EKCU6kZ+N4GNCxfwKpVOryQSuOUVhBCbsRIIuN1cWRkaSCfRrdaOTncijgltNPDn5xHZLIn7x3GNh4CVmADgcv3a9YmBY0cxm06nAQH31KlOao3BL5fxbtzAOE73hAt7JXb6RU7PGO44WK5Do1ZHw6WYAN+YM+X5S8dLXziWizVNvY5aWcFfWuq8Idsctb1Yr8DwmRwrUr1yfVMbcyYmwIWZ2mbdai9+gvfBAsaAbrUwrrtllLuJPibIGGQ2hUlIHLdlA+diTXgSqkKIt5b/OevL+8bwqlWU63anW3jyhaa4c9T2Hs0hrsL5EOCJQ/sov7/gS8Mb07AZEwDgav2D5aVy3eSziEL+Dllk0PSRcmcMqx6BUeGykINsksrttboPP4w2aVfACVhGiFevvft+I/XwJCad3DF6tc2MiD4zmRSZhyZY/OusI4V4JTqKYwIA6lr/2Gm6s5/+7UMv/egDmEyqL7VbRR/LViR6sikGvniYpffm2m6r/VFd65/0vqZ9R/tbsMeG+WKpMDL+lWMJ58Jl/NVqvOG26PAoDmCXhhg4epDl9+a9zUp1uQkPbvWfcMvZchbuEXAuk0kf2X/84YxpuDQv3kA5zW1fw9CswSyZyXFEJsmnf/m46bntuTY8+SxUtuLadri9CokxeEUK8WJhtJgaeeSIxG3RurWGv+Gg3RbaU5CwkOkU1lCWxFgBmbS4ff6qX7297rXh9Gn4/llobMcjtsFywACQ+zZMTsOP8vBIOpNS+bFiJj2cxx7MYg+k8ZwmrWqD9lqNjVvrTc9tWRtw/k345dtwFagDTmTdUUA2EDAYXffB2JPw6FH4ch7GUpCzIemD50J9A1Y+hH/8Cc4vdTq9Tud9D9dNOt+MajclyNL53xZmIhusmcBSQJLOd4UJnHqACzTppDy0kHizl/yuPRB5nggIM0A6IE4GuA34EQFtoBUQuwGm7kbwb+eaEEXmuV5dAAAAJXRFWHRjcmVhdGUtZGF0ZQAyMDA5LTExLTEwVDE5OjM4OjI0LTA3OjAwdDKp4gAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAxMC0wMi0yMFQyMzoyNjoyNC0wNzowMC7DUNYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMTAtMDEtMTFUMDg6NTc6MzUtMDc6MDCruapPAAAAMnRFWHRMaWNlbnNlAGh0dHA6Ly9lbi53aWtpcGVkaWEub3JnL3dpa2kvUHVibGljX2RvbWFpbj/96s8AAAAldEVYdG1vZGlmeS1kYXRlADIwMDktMTEtMTBUMTk6Mzg6MjQtMDc6MDArg9/WAAAAGXRFWHRTb3VyY2UAVGFuZ28gSWNvbiBMaWJyYXJ5VM/tggAAADp0RVh0U291cmNlX1VSTABodHRwOi8vdGFuZ28uZnJlZWRlc2t0b3Aub3JnL1RhbmdvX0ljb25fTGlicmFyebzIrdYAAAAASUVORK5CYII=') left center no-repeat;
}
.error-text-div {
    display: inline-block;
    vertical-align: top;
    height: 32px;
}
.label {
    font-weight:bold;
    display: inline-block;
}
.value {
    display: inline-block;
    margin-left: 5px;
}
pre {
    font-size: 110%;

May 04 '22 14:05 wildfly-ci

hi @lvydra, it looks like errors are related to your changes. Could you take a look?

May 27 '22 08:05 yersan

Hi @yersan, thanks, I will look at it.

May 27 '22 09:05 lvydra

Hi @fjuma, I think that the PR should be ready for another round of review :-) All requests should be addressed, the only persisting problem is setAlternatives validation, which I haven't been able to get working. I have added a custom validation method using alternatives attribute, however, I don't think it's a suitable solution.

Jun 23 '22 13:06 lvydra

Thanks for the updates, @lvydra! I've added some comments.

Jun 27 '22 22:06 fjuma

What is the issue you're running into with setAlternatives? Is it that it's not actually taking an effect? I wonder if it's because these attributes are only being used for runtime operations.

Jun 27 '22 22:06 fjuma

Hi @fjuma, thanks for the review, I have updated PR. Yes exactly, it doesn't take any effect.

Jun 28 '22 13:06 lvydra

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

Aug 13 '22 00:08 github-actions[bot]

This PR is still active.

@lvydra Looks like there's a conflict that now needs to be resolved.

Aug 15 '22 13:08 fjuma

Hello, lvydra. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

Aug 15 '22 23:08 wildfly-ci

Hi @fjuma, thanks, resolved.

Aug 16 '22 07:08 lvydra

@fjuma / @darranl Is there any decision about handling this as an enhancement vs Feature Request? Since there is a user controllable action here, probably it is more inclined to a Feature Request, however, it seems it doesn't change the subsystem configuration, so here are my doubts.

Sep 23 '22 09:09 yersan

@lvydra Thanks for the updates! Sorry for the delayed response, just catching up after being away for a couple weeks.

Just to check, have you already created a PR against WildFly with the corresponding community documentation?

Oct 03 '22 19:10 fjuma

Hi @fjuma, not yet, I will prepare a documentation update and open PR.

Oct 04 '22 10:10 lvydra

Hi @fjuma, I have opened documentation PR: https://github.com/wildfly/wildfly/pull/16139

Oct 06 '22 08:10 lvydra

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

Nov 21 '22 00:11 github-actions[bot]

This PR is still active.

Nov 21 '22 14:11 fjuma

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

Jan 07 '23 00:01 github-actions[bot]

This PR is still active.

Jan 09 '23 14:01 fjuma

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

Feb 25 '23 00:02 github-actions[bot]

There has been no activity on this PR for 90 days and it has been closed automatically.

May 27 '23 00:05 github-actions[bot]

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

Aug 12 '23 00:08 github-actions[bot]

This PR is still active

Aug 14 '23 14:08 fjuma

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

Sep 29 '23 00:09 github-actions[bot]

There has been no activity on this PR for 90 days and it has been closed automatically.

Dec 28 '23 00:12 github-actions[bot]

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

Mar 17 '24 00:03 github-actions[bot]

wildfly-core wildfly-core copied to clipboard

[WFCORE-5679] Generate and export operation

Failed tests

wildfly-core
wildfly-core copied to clipboard