WFLY-19229 The OpenAPI BasicRuntimeIT is ineffective and passes even …

[rhusar]

…on non-OpenAPI compliant runtime

Fixes https://issues.redhat.com/browse/WFLY-19229

[rhusar]

The whole BasicRuntimeIT is a mess as well... it's being overriden (http://localhost:8080/) but in the templates this forms URIs without the context path - and since it only chcecks for 200, it would pass anwyay...

[rhusar]

The whole BasicRuntimeIT is a mess as well... it's being overriden (http://localhost:8080/) but in the templates this forms URIs without the context path - and since it only chcecks for 200, it would pass anwyay...

Will open a Jira when Jira is back online.

[emmartins]

FYI the server host is overriden on server provisioning/bootable jar environment, and on those the app is deployed at root context, i.e. thus no context path

On Thu, 11 Apr 2024 at 16:50, Radoslav Husar @.***> wrote:

The whole BasicRuntimeIT is a mess as well... it's being overriden ( http://localhost:8080/) but in the templates this forms URIs without the context path - and since it only chcecks for 200, it would pass anwyay...

Will open a Jira when Jira is back online.

— Reply to this email directly, view it on GitHub https://github.com/wildfly/quickstart/pull/894#issuecomment-2050007748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDY6CUDHIBTLR7MA57SVLY42WLXAVCNFSM6AAAAABGCM7BKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQGAYDONZUHA . You are receiving this because your review was requested.Message ID: @.***>

[emmartins]

Wrt just checking 200, some QS have opted also to test the content, and for sure I think that’s a good decision ;-)

On Thu, 11 Apr 2024 at 16:52, Eduardo Martins @.***> wrote:

FYI the server host is overriden on server provisioning/bootable jar environment, and on those the app is deployed at root context, i.e. thus no context path

On Thu, 11 Apr 2024 at 16:50, Radoslav Husar @.***> wrote:

The whole BasicRuntimeIT is a mess as well... it's being overriden ( http://localhost:8080/) but in the templates this forms URIs without the context path - and since it only chcecks for 200, it would pass anwyay...

Will open a Jira when Jira is back online.

— Reply to this email directly, view it on GitHub https://github.com/wildfly/quickstart/pull/894#issuecomment-2050007748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDY6CUDHIBTLR7MA57SVLY42WLXAVCNFSM6AAAAABGCM7BKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQGAYDONZUHA . You are receiving this because your review was requested.Message ID: @.***>

[rhusar]

FYI the server host is overriden on server provisioning/bootable jar environment, and on those the app is deployed at root context, i.e. thus no context path … On Thu, 11 Apr 2024 at 16:50, Radoslav Husar @.> wrote: The whole BasicRuntimeIT is a mess as well... it's being overriden ( http://localhost:8080/) but in the templates this forms URIs without the context path - and since it only chcecks for 200, it would pass anwyay... Will open a Jira when Jira is back online. — Reply to this email directly, view it on GitHub <#894 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDY6CUDHIBTLR7MA57SVLY42WLXAVCNFSM6AAAAABGCM7BKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQGAYDONZUHA . You are receiving this because your review was requested.Message ID: @.>

Gotcha, good point. So only affecting this specific scenario.

[openshift-ci[bot]]

@rhusar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/wildfly-quickstart-e2e	d2e1b6974788b560baebee80a9fac47b80482ec9	link	true	/test wildfly-quickstart-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.