wildfly-jar-maven-plugin icon indicating copy to clipboard operation
wildfly-jar-maven-plugin copied to clipboard

CLOUD-4211 Cloud clustering profiles should configure a distributed caches instead of a replicated ones

Open rhusar opened this issue 1 year ago • 2 comments

Resolves https://issues.redhat.com/browse/CLOUD-4211

rhusar avatar Jun 06 '24 15:06 rhusar

@rhusar , there is a failing test. We are looking for the content "default-cache="repl"" there: https://github.com/wildfly-extras/wildfly-jar-maven-plugin/blob/main/tests/src/test/java/org/wildfly/plugins/bootablejar/maven/goals/DefaultCloudConfigurationTestCase.java#L51 This would have to be updated to reference a token in the config that is specific to the cloud configuration.

jfdenise avatar Jun 17 '24 12:06 jfdenise

@jfdenise Ah, thanks, will fix that - but it's hard to see what's failing since tests are failing both locally and on CI in main as well (latest push https://github.com/wildfly-extras/wildfly-jar-maven-plugin/commit/c1b0b0e37c259425b22ca1c6a767b05731f872ac)

rhusar avatar Jun 17 '24 12:06 rhusar

@rhusar is still in the plan? Could you rebase your branch, thank-you.

jfdenise avatar Nov 28 '24 12:11 jfdenise

@rhusar is still in the plan? Could you rebase your branch, thank-you.

Will do, thanks for the ping @jfdenise

rhusar avatar Nov 29 '24 14:11 rhusar

@rhusar , do you want it in 12.0.0.Final? Would you mind rebasing and e-run the tests? Thank-you.

jfdenise avatar Dec 18 '24 09:12 jfdenise

@jfdenise Yes, will do that shortly today!

rhusar avatar Dec 18 '24 09:12 rhusar

Sigh... the CI won't run as I am not a member of wildfly-extras.

rhusar avatar Dec 18 '24 12:12 rhusar

@pferraro Could you please review? Thanks!

rhusar avatar Dec 18 '24 13:12 rhusar

@rhusar thank-you, merged.

jfdenise avatar Dec 18 '24 14:12 jfdenise

@rhusar thank-you, merged.

Thanks and sorry for the delay on this as I was working in a whole different area :-)

rhusar avatar Dec 18 '24 14:12 rhusar