Wikum Weerakutti comments

Results 66 comments of


                                            Wikum Weerakutti

TRUNK-6081: Add not null constraint to encounter_diagnosis.dx_rank

@wluyima I added a comment to describe the changeset.

TRUNK-6081: Add not null constraint to encounter_diagnosis.dx_rank

@wluyima Are there any additional changes I should make in this PR??

TRUNK-6081: Add not null constraint to encounter_diagnosis.dx_rank

New PR: https://github.com/openmrs/openmrs-core/pull/4199

TRUNK-6203: Global properties access should be privileged

@dkayiwa Yes, Everything seems fine on my end.

TRUNK-6203: Global properties access should be privileged

@dkayiwa I updated the PR.

TRUNK-6203: Global properties access should be privileged

@dkayiwa Yes, Are you getting any errors?

TRUNK-6203: Global properties access should be privileged

@dkayiwa, I've made updates to the PR. Additionally, I've created pull requests for the modules to enable anonymous users to access the login page. openmrs-module-uiframework : https://github.com/openmrs/openmrs-module-uiframework/pull/77 openmrs-module-referenceapplication : https://github.com/openmrs/openmrs-module-referenceapplication/pull/104...

TRUNK-6203: Global properties access should be privileged

@dkayiwa main issue here is users won't be able to access the login page because of that.

TRUNK-6203: Global properties access should be privileged

@dkayiwa I have created another PR for this using a different approach: https://github.com/openmrs/openmrs-core/pull/4617 What method do you suggest?

TRUNK-6203: Global properties access should be privileged

@dkayiwa, it's crucial to use try-finally when using the addProxyPrivilege method. Without it, we risk being unable to remove the privilege in case of an exception. This approach aligns with...