wikimedia
Deep Link support added for places
Background Context:
I have added deep link support for places in the Wikipedia app. So, when the Wikipedia app is opened through the deep link, it will directly go to the ‘Places’ tab and show the location specified by the caller app.
In this PR:
- Added deep link support for location coordinates (latitude & longitude) and name.
- Used existing logic to search places with coordinates.
- Used existing logic to search places with names.
Testing Steps:
Please use the following deep link patterns
- With coordinates:
wikipedia://places?WMFArticleURL=https://en.wikipedia.org/wiki?place=Amsterdam&latitude=52.3547498&longitude=4.8339215 - With location name:
wikipedia://places?WMFArticleURL=https://en.wikipedia.org/wiki?place=Berlin
Screenshot/demo:
https://github.com/user-attachments/assets/3546f134-7a07-4e86-ab53-19cc5c77a07e
@raihan Thanks for the improvement! I have created an associated Phabricator task so that we can track it's status on our workboard - https://phabricator.wikimedia.org/T377343.
I notice this is still marked as Draft. Is there anything you need from us before marking this as Ready for Review?
@raihan Thanks for the improvement! I have created an associated Phabricator task so that we can track it's status on our workboard - https://phabricator.wikimedia.org/T377343.
I notice this is still marked as Draft. Is there anything you need from us before marking this as Ready for Review?
I opened the PR.
Hi @raihan, just checking in to see if you were able to take a look at Toni's comments. Let us know if you need assistance.
Hi @raihan, I'm going to close this to clear up our board. Feel free to reopen with the feedback addressed and we will take another look. Thank you!