jquery.i18n icon indicating copy to clipboard operation
jquery.i18n copied to clipboard

fix: TypeError for numeric values

Open deepikap1 opened this issue 6 years ago • 4 comments

@gwhenne, please review this pull request. Should resolve #176 .

deepikap1 avatar Aug 21 '18 23:08 deepikap1

Works correctly in my test case - thank you!

gwhenne avatar Aug 22 '18 11:08 gwhenne

According to https://api.jquery.com/data/#data-html5 you can use $this.attr( 'data-i18n' ) to retrieve the value directly as a string. However, its behavior may differ in a few cases (e.g. message keys resembling arrays, programmatic use of .data()).

ricordisamoa avatar Aug 23 '18 11:08 ricordisamoa

@ricordisamoa Should I make the changes or is my previous commit fine?

deepikap1 avatar Aug 24 '18 21:08 deepikap1

@Deepikap1 dd1beba looks unrelated commit here.

kartikm avatar Aug 27 '18 04:08 kartikm