jquery.i18n icon indicating copy to clipboard operation
jquery.i18n copied to clipboard

Published 20 hours ago • verified publisher icon wikimedia

Remove Dependency on jQuery

Open davidbarratt opened this issue 6 years ago • 5 comments

Is there any reason this library needs jQuery?

Perhaps the majority of this library should be moved to a generic JavaScript library and this package can wrap the new library with jQuery (in order to preserve backwards compatibility).

davidbarratt avatar Feb 26 '18 20:02 davidbarratt

Yes, Agree. See https://github.com/wikimedia/jquery.i18n/issues/83. I started some initial work on this and now stalled due to time constraints.

santhoshtr avatar Feb 27 '18 03:02 santhoshtr

I ended up creating React bindings for this library: https://github.com/wikimedia/InteractionTimeline/tree/master/client/src/components/i18n It can (and probably should) be split out into a separate library.

So in the end, I think it would be best if we had a JavaScript i18n library, and then a library that provides jQuery bindings and another that provides React bindings (or any other library someone wants to write bindings for)

davidbarratt avatar Mar 13 '18 17:03 davidbarratt

I've moved the React bindings into a separate library: https://github.com/wikimedia/react.i18n

davidbarratt avatar Jul 20 '18 08:07 davidbarratt

I am working on this again - to build a generic, modern js library https://github.com/santhoshtr/banana-i18n

Please take a look.

santhoshtr avatar Nov 23 '18 10:11 santhoshtr

AMAZING!

I created a few issues for it. I don't see anything major. When it's published on npm I'll put it in https://github.com/wikimedia/react.i18n and see if the tests pass (I don't see why they wouldn't).

Thank you @santhoshtr for doing this!

davidbarratt avatar Nov 23 '18 17:11 davidbarratt