apps-android-wikipedia icon indicating copy to clipboard operation
apps-android-wikipedia copied to clipboard

Log remaining instruments via Metrics Platform

Open cjming opened this issue 2 years ago • 2 comments

After verifying data coming thru in a recent pre-prod beta release, this PR proposes to submit events for the remaining Android instruments (currently submitted via Modern Event Platform) via Metrics Platform.

The following instruments are included for Metrics Platform integration:

  • AppearanceSettingInteractionEvent
  • AppSessionEvent
  • BreadcrumbLogEvent
  • CreateAccountEvent
  • CustomizeToolbarEvent
  • DailyStatsEvent
  • EditHistoryInteractionEvent
  • InstallReferrerEvent
  • NotificationInteractionEvent
  • UserContributionEvent

Some new MP classes aim to consolidate a few of the above instruments. If it is preferred to keep naming conventions 1:1, I can adjust accordingly.

Note: these changes are purely additive - no changes should occur with current event logging.

Bug: T330355

cjming avatar Aug 07 '23 18:08 cjming

hi @dbrant @sharvaniharan @cooltey -- Q re: 2 instruments that have config but code does not seem to exist:

  • image_recommendation_interaction
  • article_page_scroll_interaction

I didn't include the two above in this PR even tho their corresponding tables do exist in Hive (23 rows in android_image_recommendation_interaction and 0 rows in android_article_page_scroll_interaction).

Just flagging this for your team -- should their configs be removed?

cjming avatar Aug 07 '23 19:08 cjming

also, apologies that this is a rather big change set -- as I was making changes, it seemed like some of the same files were being touched so i thought doing it in one go might be easier to reconcile

if it's helpful, i can break it up into smaller PRs

cjming avatar Aug 08 '23 15:08 cjming