twinkle icon indicating copy to clipboard operation
twinkle copied to clipboard

Create menus for monobook and modern skins

Open siddharthvp opened this issue 4 years ago • 8 comments

I see that @MusikAnimal's MoreMenu provides menus in monobook and modern skins too, whereas Twinkle does so only for vector. The individual tabs take up a lot of space, and causes other scripts' buttons to be hidden if user has too many of them. Maybe the code can be copied over? Or is there something else to be wary about?

siddharthvp avatar Oct 01 '19 05:10 siddharthvp

@Amorymeltzer you use modern but have never felt a need for this?

siddharthvp avatar Oct 01 '19 14:10 siddharthvp

MoreMenu is actually only Vector. The Monobook/Modern version you see is User:Haza-w/Drop-down menus, which is no longer maintained. I am working on a new version of MoreMenu that works in all skins, and is localizable. I haven't gotten around to how I'm going to add menus yet, but it will probably mimic Haza-w's implementation. I am a Vector user myself but I suspect non-Vector users might enjoy similar menu functionality for Twinkle.

MusikAnimal avatar Oct 01 '19 17:10 MusikAnimal

I've been using modern for nearly 15 years now, so I think it's just inertia? Even with all the extra sysop and twinkle tabs and a few my own stuff, I've only had one or two issues since I hide a bunch I don't care about. I've been meaning to try haza's thing for a while, but, again, inertia/workflow/etc.

What @MusikAnimal suggests — make him do the hard work then adapt for Twinkle — seems like a great plan to me!

Amorymeltzer avatar Oct 01 '19 23:10 Amorymeltzer

I see the code is at MediaWiki:Gadget-dropdown-menus-nonvector.js. I plan to get to it over the weekend.

siddharthvp avatar Oct 02 '19 04:10 siddharthvp

Got a request for MonoBook support today by Vitaium. https://en.wikipedia.org/wiki/Wikipedia_talk:Twinkle#New_features_request

NovemLinguae avatar Feb 25 '22 00:02 NovemLinguae

Modern is not on the list of skins on enwiki, so could possibly be prioritized lower or removed from the ticket.

Screenshot of the issue in MonoBook this ticket would fix: image

NovemLinguae avatar Feb 25 '22 01:02 NovemLinguae

Modern is not on the list of skins on enwiki

It's still there, they just removed it from the list in Special:Preferences because it's unmaintained. That happened since this ticket was opened, so I agree we shouldn't compelled to spend a lot of time on Modern support, even though it presumably is still being used by Twinkle users (such as Amorymeltzer).

MusikAnimal avatar Feb 25 '22 01:02 MusikAnimal

Screenshot for that too just in case: 2022-02-24_175104

NovemLinguae avatar Feb 25 '22 01:02 NovemLinguae