afch-rewrite icon indicating copy to clipboard operation
afch-rewrite copied to clipboard

writing to userspace AFC_log should default to turned on

Open NovemLinguae opened this issue 1 year ago • 1 comments

Any reason not to?

https://apersonbot.toolforge.org/afchistory/ exists but only goes back 6 months due to G13.

Turning this on by default would mean more AFC editors have this log, which would increase transparency and auditing ability. They could still turn it off in AFCH preferences.

I think it currently defaults to turned off (I found a newer AFC reviewer today with no log), but I have not verified yet. Will need to dig into the AFC preference system a bit more.

Looks like user preferences are stored in browser Local Storage under the key userjs-afch-preferences.

image

Guess we should probably default logCsd to true too.

https://github.com/wikimedia-gadgets/afc-helper/blob/4bef276b8e675ea50fbfa80aa9ea9d25b0c65af6/src/modules/core.js#L1310-L1328

https://github.com/wikimedia-gadgets/afc-helper/blob/4bef276b8e675ea50fbfa80aa9ea9d25b0c65af6/src/modules/core.js#L1132-L1164

NovemLinguae avatar Jul 18 '23 23:07 NovemLinguae

I think in this case a default-on would be a good thing, since there is a bit more data in there (for example) for reviewing probationary member activity. Since it's all script-based it's not like people are having to actually do anything so most might not even notice....

primefac avatar Jul 19 '23 07:07 primefac