afch-rewrite
afch-rewrite copied to clipboard
Still some bugs while using multiple decline reasons
The code implementing multiple decline reasons needs to be looked over again, because I think there are still more bugs. I'm sure there are bug reports somewhere on WT:WPAFC.
The main issue is when reason2
contains a value that would normally have a secondary input (such as the language, merge target, or URL) that secondary input is not automatically included and needs to be added manually.
I'm likely misremembering, but I actually think that is the issue.
That's certainly part of it, if not all of it. From the report at https://en.wikipedia.org/w/index.php?diff=958290240, the generated template was:
{{AFC submission|d|v|Spanish|u=Gianluigi Feliu|ns=118|decliner=Robert McClenon|declinets=20200522233914|reason2=lang|ts=20200522225318}}
"Spanish" should've gone to details2, not details (aka anonymous parameter 3).