hammer.vim icon indicating copy to clipboard operation
hammer.vim copied to clipboard

Add support for the new GitHub README template.

Open ghost opened this issue 13 years ago • 7 comments

I'd love the new GitHub README template to be available as the new default. The current default could be renamed github_old.

ghost avatar Mar 17 '12 03:03 ghost

Yeah, I'm working on it, and will release it at the end of the week.

wikimatze avatar Mar 18 '12 21:03 wikimatze

It's done - see commit https://github.com/matthias-guenther/hammer.vim/commit/078cb118b156f46be01c5dedf80ec3aaeae3f283

wikimatze avatar Mar 19 '12 15:03 wikimatze

Thanks! I think it might need to be tweaked, though, because the font is not the same and the padding on <li> elements seems to be different as well. I think it could be cool if we wrapped the README in the same UI element that GItHub is using. Thoughts?

ghost avatar Mar 19 '12 17:03 ghost

See commits https://github.com/matthias-guenther/hammer.vim/compare/b67eed84a7...eb1cec166d - in my eyes it should fit now.

wikimatze avatar Mar 25 '12 08:03 wikimatze

Is the layout okay for now or should I ask the github people for their layout?

wikimatze avatar Apr 26 '12 06:04 wikimatze

I think the layout is closer but not close enough. The original README template(old github theme) was almost identical, and I'd like the new template to have the same level of similarity. I don't think we need to ask GitHub for their markup, I think the layout can be easily matched (we're aiming for 95%+ similarity, not 100%). After that, we just need to apply similar CSS rules to make sure everything matches.

I see the old github theme is totally gone as well, I think we should keep it around, maybe as github-legacy.

ghost avatar Apr 26 '12 19:04 ghost

github-legacy is a good idea - I will restore it this evening.

wikimatze avatar May 02 '12 13:05 wikimatze