wigy
wigy
Hi @mrbianchi! Does the latest https://github.com/maciejhirsz/tiny-bip39 also miss your expected results? There is an unfixed issue #21 on this codebase.
Without sharing your valuable master secrets, could you please provide here a sample Spanish mnemonic, your expected seed and what you actually got?
> This crate has a bug. I noticed it doesn't have any unit test that verifies the implementation against the test vectors in the BIP39 spec. Actually, it is "only"...
I found some in the NBitcoin project. NBitcoin/NBitcoin. https://github.com/MetacoSA/NBitcoin/tree/master/NBitcoin.Tests/data
Maybe this could be an interesting codefix: Not normalized input for Japanese phrases to test normalization: https://github.com/bip32JP/bip32JP.github.io/commit/360c05a6439e5c461bbe5e84c7567ec38eb4ac5f (I do not speak Japanese, so I would need to rely on these...
So a Japanese and English mnemonic for the same entropy results in a different seed based on BIP39. **That** I overlooked as well. Thanks.
@steveatinfincia Could you please have a look and consider merging this PR to v0.6, which includes the failing tests in #17 plus the fixes in the seed generation?
Okay, this PR went a bit stale. I keep [this fork](https://github.com/Internet-of-People/bip39-rs) up-to-date with the fixes for now, but I would be glad to drop it in favor of this upstream.
Hi Stephen @steveatinfincia ! Do you have some plans on how to progress forward with stabilizing the 0.6 release with or without this branch? You have not reacted to this...
This bug seems to be fixed in v8.something already.