Stepan Kolesnik

Results 15 comments of Stepan Kolesnik

What would be really awesome if an Eclipse-like feature could be implemented which would allow assigning regexp-based file sets to a Checkstyle configuration(s). I.e.: /src/main/java/._.java - checkstyle_main.xml /src/._test/java - checkstyle_test.xml...

Does anybody know of a solution for this? Running on 0.14.6

Is there any update on this? Any plans to get the PR merged?

I have taken a shot at it: https://github.com/joelittlejohn/jsonschema2pojo/pull/1380 Please can somebody have a look?

This PR supersedes https://github.com/joelittlejohn/jsonschema2pojo/pull/1008 and https://github.com/joelittlejohn/jsonschema2pojo/pull/1160

> As you are writing this PR supersedes #1160, what is the reason you created this PR? Not sure I fully understand the question. I have added this PR in...

@hupfdule wow, many thanks for such a thorough review and your comments! I will address all of them individually soon, but the main priority is of course the functionality deficiency...

@hupfdule, I have tried to reproduce the issue with the generation you have described, but I was unable to. I have added more explicit integration tests now, specifically [canGenerateTheWholeDirectory()](https://github.com/joelittlejohn/jsonschema2pojo/pull/1380/files#diff-d847115fce1a24348f604276cd49b8122a9071288ebbcb338c35dd50051593e3R62) which...

> Yes, it seems I was wrong. I didn't test it thoroughly, but it seems to be working. Great! Thanks for confirming! > But you should definitely not introduce changes...

Funny you mentioned it! I did kind of forget about it for some time, but just yesterday I re-stumbled upon and was planning on getting the PR back into shape...