ciphereditor icon indicating copy to clipboard operation
ciphereditor copied to clipboard

Dev container configurations into dev branch

Open robigan opened this issue 2 years ago • 9 comments

Add certain configurations that allow for the repository to be seamlessly opened in a local dev container in VSCode, Docker Dev Containers, or GitHub Workspaces. Also add configuration for VSCode Monorepo workspace support

robigan avatar Aug 29 '22 14:08 robigan

Gonna take a shower and then fix the changes

robigan avatar Aug 29 '22 18:08 robigan

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ciphereditor ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 8:32PM (UTC)

vercel[bot] avatar Aug 29 '22 19:08 vercel[bot]

Awesome! Thank you! How should we let people know about all of this in the README? Should we add a badge like in https://github.com/microsoft/vscode-remote-try-node?

If you want, I can update the README with these setup steps and add the VSCode Remote Containers badge

robigan avatar Aug 30 '22 07:08 robigan

Yes, please! It would round off this pull request. I'd keep the dev container setup as an alternative to the current setup, though. Let's divide the development setup section into two.

ffraenz avatar Aug 30 '22 07:08 ffraenz

Ok, I finally managed to fix my docker setup after realizing that I had to install some kernel modules and then forgetting to restart cus of new kernel. But alright let me do that rq

robigan avatar Aug 30 '22 09:08 robigan

@robigan I've committed my suggestion for the README into the PR. What do you think?

ffraenz avatar Aug 30 '22 21:08 ffraenz

After further thought I'm making the conventional setup the primary option here as it does not require the use of Docker or Visual Studio Code. Still, I want to roll with dev containers and see where it leads us. I hope you can relate.

ffraenz avatar Aug 30 '22 22:08 ffraenz

I totally agree, that is why I left the conventional setup at the top of the setup instructions, as those are the first instructions the human eye will see. If you're willing to mark it as primary to make it easier, then please go ahead

robigan avatar Aug 31 '22 06:08 robigan

@robigan I've committed my suggestion for the README into the PR. What do you think?

TBH you did a much better job than I did, your changes on the README or way cleaner than mine hahaha

robigan avatar Aug 31 '22 06:08 robigan