tinycarousel icon indicating copy to clipboard operation
tinycarousel copied to clipboard

Last item cropped with infinite: false

Open Chanixy opened this issue 10 years ago • 5 comments

Hi,

I think the last item is cropped when infinite is set to false. The provided example has the same behaviour. Tested on Iceweasel 24.4. Is there something particular that must be done in css/js for this mode ?

thank you for the nice feature anyway.

Chanixy avatar May 11 '14 13:05 Chanixy

Well.. I set it to false... And I still have the first element copied and added at the end with the class mirrored. So it's clearly not working as intended.

rdomingue avatar Oct 02 '14 18:10 rdomingue

I to have the same issue as rdomingue. Setting infinite to false doesn't stop the loop as expected.

ghost avatar Oct 08 '14 12:10 ghost

For a quick fix I just removed these 2 lines : $overview.find(".mirrored").remove(); $overview.append($slides.slice(0, slidesVisible).clone().addClass("mirrored"));

It's not the best way to do things... but as I said... for a quick fix, it's do the job.

rdomingue avatar Oct 08 '14 12:10 rdomingue

dont do a quick fix, do a pull request with proper code changes :)

lpaulger avatar Oct 13 '14 16:10 lpaulger

Well as I said, it was a quick fix for a quick purpose, not for a long term use and full support. For now I'll not pull request.

rdomingue avatar Oct 13 '14 21:10 rdomingue