commonsbooking icon indicating copy to clipboard operation
commonsbooking copied to clipboard

phpunit tests verursachen Warningen

Open nelarsen opened this issue 7 months ago • 2 comments

Ich erstelle mehrere PR, um Warnungen untern "Run test suite" für PHP Unit Tests los zu werden:

  • [x] fix TimeframeTest::testRemoveIrrelevantPostmeta(), update_post_meta was called with object rather than post ID #1608
  • [x] fix tests/php/Service/BookingRuleAppliedTest.php & tests/php/Repository/TimeframeTest.php, avoid "Creation of dynamic property" (deprecation from php 8.2) #1607
  • [x] src/Map/SearchShortcode.php change style string interpolation #1609
  • [x] tests/php/View/BookingTest_AJAX_Test.php, fix BookingTest_AJAX_Test that was not cleaning up created BookingCodesTable #1610
  • [x] fix BookingCodesMessage::sendMessage() for case when sending of ICal attachment is disabled (default). Then a non-empty (!) array with a single null element was passed to prepareMail(), making the check !empty($attachment) in * SendNotificationMail() return true ("there are attachments" even if there is just a null in an array) and causing warnings due to wrong use of PHPmailer. #1606
  • [ ] Der Test CommonsBooking\Tests\Service\SchedulerTest::testCustomRecurrence schlägt manchmal zufällig (laufzeitbedingt) fehl: Failed asserting that 1719824258 matches expected 1719824259. Wenn er fehlschlägt, immer um 1 sekunde.

nelarsen avatar Jul 01 '24 09:07 nelarsen