solara icon indicating copy to clipboard operation
solara copied to clipboard

Published 20 hours ago • verified publisher icon widgetti

ci: run pre commit in ci for code quality

Open maartenbreddels opened this issue 2 years ago • 3 comments

maartenbreddels avatar Jul 31 '23 11:07 maartenbreddels

Instead of manually keeping pre-commit versions in sync with CI, lets also use pre-commit in CI

maartenbreddels avatar Jul 31 '23 11:07 maartenbreddels

Giving up for now, I have no idea why isort under Python 3.9 decides to reorder imports.

maartenbreddels avatar Jul 31 '23 15:07 maartenbreddels

After d15ec01a36b8a08a2eacead857a3ba36bace1352 it seems that we cannot install isort on Python 3.7 anymore. Might be a clue that the isort on 3.9 in pre commit does not respect the version number in the pre commit file.

maartenbreddels avatar Jul 31 '23 15:07 maartenbreddels