ipyvolume icon indicating copy to clipboard operation
ipyvolume copied to clipboard

fix: support numpy2 compatibility

Open flokli opened this issue 7 months ago • 3 comments

Since numpy2 we need to explicitly decide how to deal with values out of range.

flokli avatar Apr 30 '25 09:04 flokli

I think that's a reasonable fix. Is this compatible with numpy 1? If not, can we make it compatible?

maartenbreddels avatar May 01 '25 08:05 maartenbreddels

Both functions exists in 1.26, so I'd say yes. It's a bit hard to test for me in this environment, as numpy2 propagates from all other inputs as well and would need to be replaced.

flokli avatar May 01 '25 08:05 flokli

I tried to do the overrides in downstream dependencies (bqplot, bqscales, pandas), but it's not possible to build pandas with numpy 1 anymore, making it really hard for me to test here.

Are you able to run the tests from your side, with a numpy 1 in the environment?

flokli avatar May 01 '25 09:05 flokli