ipyvolume icon indicating copy to clipboard operation
ipyvolume copied to clipboard
verified publisher icon widgetti

UI Tests check is failing on CI

Open jtpio opened this issue 3 years ago • 2 comments

Opening a new issue since the check is failing on the latest commit on master: https://github.com/widgetti/ipyvolume/commit/1c08f9fdde4219be873f7c45e02ecec2540d5876

image

Opening the report shows some differences with the UI elements:

image

Not sure if this was introduced in a previous PR, but probably updating the reference snapshots should help fix it.

jtpio avatar Jul 27 '22 07:07 jtpio

Also the UI Tests setup could be updated to use a more recent @jupyterlab/galata based on Playwright: https://github.com/jupyterlab/jupyterlab/tree/master/galata

For example:

  • https://github.com/voila-dashboards/voila/tree/main/ui-tests
  • https://github.com/jupyter-widgets/ipyleaflet/tree/master/ui-tests

jtpio avatar Jul 27 '22 07:07 jtpio

Upgrading to the newer setup would also allow for integrations like automated snapshots updates with a bot: https://github.com/jupyterlab/maintainer-tools#update-snapshots

jtpio avatar Jul 27 '22 08:07 jtpio

Partially fixed in https://github.com/widgetti/ipyvolume/pull/424 (not yet upgraded, will keep that in mind!)

maartenbreddels avatar Jan 27 '23 13:01 maartenbreddels