ipyvolume icon indicating copy to clipboard operation
ipyvolume copied to clipboard

Support ipywidgets 8

Open jtpio opened this issue 3 years ago • 6 comments

Start testing support for ipywidgets 8.

Similar to https://github.com/matplotlib/ipympl/pull/461

jtpio avatar Jul 26 '22 08:07 jtpio

Thanks!

Visual differences I'm ok with, do you know if the lab2 build can be fixed?

maartenbreddels avatar Jul 26 '22 08:07 maartenbreddels

do you know if the lab2 build can be fixed?

Wondering if this might be related to https://github.com/jupyterlab/jupyterlab/issues/11248 according to the log in https://github.com/widgetti/ipyvolume/runs/7516085636?check_suite_focus=true.

jtpio avatar Jul 26 '22 12:07 jtpio

Opened https://github.com/widgetti/ipyvolume/pull/412 to start troubleshooting this.

jtpio avatar Jul 26 '22 12:07 jtpio

Ah, I think we need to manually push the visual changes right? Is there a bot that can do that for us?

maartenbreddels avatar Jul 26 '22 15:07 maartenbreddels

I opened https://github.com/widgetti/ipyvolume/issues/413 since this does not seem related to this change.

jtpio avatar Jul 27 '22 07:07 jtpio

Bringing this PR out of draft since ipywidgets 8 was released yesterday.

jtpio avatar Aug 19 '22 08:08 jtpio

Failure needs network related. Thanks Jeremy!

maartenbreddels avatar Jan 27 '23 13:01 maartenbreddels