No rendering using 2D marker types

[zbouslikhin]

Hi,

First of all, many thanks for this wonderful library!

While using ipyvolume version 0.6.0a2, I came across a bug where, while trying to plot a scatter using 2D marker types (‘point_2d’, ‘square_2d’, ‘triangle_2d’), this won't render and will only load a blank figure.

Hope that I made it clear.

Cheers, Z.B

[KatharineShapcott]

Hi, I'm having the same problem on version 0.6.0a5 for all 2D marker types. In the console I can see an error: THREE.WebGLShader: Shader couldn't compile. THREE.WebGLShader: gl.getShaderInfoLog() vertex ERROR: 0:246: 's' : undeclared identifier

This seems to be coming from scatter-vertex.glsl and looks like it was introduced in #305 when s was renamed to size_scalar.

I think all this would take is a simple rename of s to size_scalar in line 108 (and possibly also dividing by 100?) but I can't test it right now so I don't want to make a pull request.

Thanks for your help. Katharine