feat: confirm before exit on mobile devices
Replace this paragraph with a description of what this PR is changing or adding, and why.
List of issues which are fixed by the PR
when we accidentally click on Hardware button in Android, whole application is closed.
Screenshots
If applicable, add screenshots to help explain the changes.
Checklist
- [ ] I signed the CLA.
- [ ] I listed at least one issue that this PR fixes in the description above.
- [ ] I updated/added relevant documentation (doc comments with
///). - [ ] I added new tests to check the change I am making].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on Discord.
Hello, I added your version into my test project but exit dialog doesn't show me.
@mjablecnik The change have been made on this file https://github.com/IvanGael/widgetbook/blob/main/packages/widgetbook/lib/src/layout/mobile_layout.dart
Just a question! In the widgetbook project folder, which folder should I run in order to test the changes?
@IvanGael
In the widgetbook project folder, which folder should I run in order to test the changes?
You can run some example and test it there..
Hello @mjablecnik I tested a full example here https://github.com/widgetbook/widgetbook/tree/main/examples but I don't see any change despite the fact that some changes have been made on this file https://github.com/IvanGael/widgetbook/blob/main/packages/widgetbook/lib/src/layout/mobile_layout.dart
Hello @IvanGael 👋
Please make sure that your development environment is set up correctly. It seems like you are using the hosted Widgetbook package and not the local one, which has the changes you made.
To do so set up everything correctly, use melos as mentioned here.
@YoussefRaafatNasry I set up melos and it seems everything is good. How to use the local widgetbook package instead of which is hosted ?
@IvanGael After installing melos, you need to:
- Undo all the
pubspec.lockfiles changes in this PR. - Run
melos bsto install the dependancies and use the local Widgetbook version.
@IvanGael Any progress?
@mjablecnik Not done yet. I need to take a look on this because i have tried what @YoussefRaafatNasry suggested to me but It seems there is any changes
I will be closing this PR for staying stale. Please re-open a new one once it's ready to review.