slack-black-theme icon indicating copy to clipboard operation
slack-black-theme copied to clipboard

Threads remains white

Open yousefcodes opened this issue 6 years ago • 15 comments

The "All Threads" view remains white.

yousefcodes avatar Mar 27 '19 19:03 yousefcodes

Just gave it all a whirl and the message body where the conversation happens is still white on version 3.3.8. Everything else turned black as it should have. I also pulled down the latest CSS local and tried that but got some results.

abstractamcr avatar Mar 31 '19 04:03 abstractamcr

For me the same!

devbyray avatar Apr 03 '19 09:04 devbyray

@abstractamcr and @raymonschouwenaar try using the css from my fork. You can use the following url while we wait for the changes (#90 ) to be merged. https://mmiraldi.github.io/slack-black-theme/custom.css After the merge, I plan to rebase my fork on @Nockiro 's because that seems to be the most comprehensive and well maintained relative to Slack version changes: https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css

mmiraldi avatar Apr 03 '19 16:04 mmiraldi

Works for me... the "All Threads" is now black. But there is an issue with the left menu. I get the "All Threads" which falls behind the "Jump to" search box... as you can hopefully see from this small screenshot: https://pasteboard.co/I8rSBEu.png

derkling avatar Apr 03 '19 16:04 derkling

@derkling that issue exists in the head of branch:master and is not addressed by #90 ... I purposefully constrained the scope of that pull request to maximize the probability of a quick merge to fix op's issue. The "Jump to" overlap (among other issues) is fixed in the second css of my above comment. Unfortunately pull request #60 has been waiting since 2018-07-21 and that fork has diverged more since then (credit to @Nockiro for keeping up with Slack developments).

mmiraldi avatar Apr 03 '19 17:04 mmiraldi

@abstractamcr and @raymonschouwenaar try using the css from my fork. You can use the following url while we wait for the changes (#90 ) to be merged. https://mmiraldi.github.io/slack-black-theme/custom.css

Forgive a silly question, but Where does this go? Do I copy the content into the two files as per the normal instructions? Or does custom.css just go in that folder?

Snowflake6 avatar Apr 08 '19 16:04 Snowflake6

@Snowflake6 it goes in the below part of the Javascript you add to the bottom of the files: // Fetch our CSS in parallel ahead of time const cssPath = 'https://cdn.rawgit.com/widget-/slack-black-theme/master/custom.css';

bwright2810 avatar Apr 09 '19 22:04 bwright2810

@Snowflake6 it goes in the below part of the Javascript you add to the bottom of the files: // Fetch our CSS in parallel ahead of time const cssPath = 'https://cdn.rawgit.com/widget-/slack-black-theme/master/custom.css';

Doh! Of course. [edit] Yep, that's fixed it. Had to re-start Slack to get everything to re-load properly, but now i've got dark backgrounds in both main window and in the reply threads. And as a bonus, the input field for posting and replying now has better contrast so I can see what i'm typing... Thanks!

Snowflake6 avatar Apr 09 '19 22:04 Snowflake6

For your security don't use the link directly it may create xss. Copy paste that css. Btw is it completely working on https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css ?

alikrc avatar Apr 12 '19 08:04 alikrc

For your security don't use the link directly it may create xss. Copy paste that css. Btw is it completely working on https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css ?

Worked perfectly for me! Thank goodness, my eyes are saved. Thank you!

SympaticoIV avatar Apr 14 '19 01:04 SympaticoIV

I signed up just to say thanks! My eyes thank you. Had this same problem and switching to the new CSS link worked!

ATLTrailBlazer avatar May 01 '19 13:05 ATLTrailBlazer

New CSS link works just fine ;) Thanks !

ghost avatar Jun 04 '19 16:06 ghost

This worked for me, css wise, FINALLY no more white background! However, I am now getting this weird button overlay in the top left, which feels a bit janky. I can't seem to get rid of the "jump to" quick search. Anyone else?

Screenshot 2019-06-21 at 10 32 50

webbydevvy avatar Jun 21 '19 09:06 webbydevvy

For those that might still be unsure of how to resolve this issue:

Open your Slack application package contents and go into:

Contents/Resources/app.asar.unpacked/src/static/ssb-interop.js

Then, go to the line that declares the cssPath variable and change it from:

const cssPath = 'https://cdn.rawgit.com/widget-/slack-black-theme/master/custom.css';

to:

const cssPath = 'https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css';

Restart the app and it should be looking better!

eduardoRubioG avatar Jun 26 '19 18:06 eduardoRubioG

const cssPath = 'https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css'; ^ worked best for me. The Previous css replacement in the comments above worked, but not on the text in a "Thread" ( in this case, standup_alice bot)

willpetty avatar Jun 27 '19 14:06 willpetty