slack-black-theme icon indicating copy to clipboard operation
slack-black-theme copied to clipboard

New Slack Update 3.0.5 breaks this hack

Open jimkiely-brainiacdevs opened this issue 6 years ago • 17 comments

The new slack 3.0.5 update breaks this hack in Window 10.

I have the readme code in the ssb-interop.js file. This worked for the past update, but not in 3.0.5. Anyone else having the same issue?

jimkiely-brainiacdevs avatar Jan 23 '18 14:01 jimkiely-brainiacdevs

Yep, I can confirm this as well on Linux[1]. @widget- have you been able to reproduce this also?

[1]: Fedora 27 - 4.14.13-300.fc27.x86_64

Kredns avatar Jan 23 '18 17:01 Kredns

On mac it seemed to revert my text color. Using a low contract theme made it very difficult to read. I ended up modifying the background css to be a bit lighter for now.

spinegar avatar Jan 23 '18 23:01 spinegar

Confirm. Xubuntu 16.04 amd64. Ignore theme, like nothing add to index.js

yshinkarev avatar Jan 24 '18 07:01 yshinkarev

Confirm, win 10

nektobit avatar Jan 24 '18 09:01 nektobit

Have you tried using this? I am definitely using 3.0.5 and it's working on Windows 10.

david1602 avatar Jan 24 '18 11:01 david1602

@david1602 thanks, it's solve issue on my system.

yshinkarev avatar Jan 24 '18 11:01 yshinkarev

@david1602 that isn't working on 3.0.5 on OSX

Edit: I stand corrected. I missed the line about adding it to ssb-interop.js. I thought it was a replacement to what you add in index.js

jer-tx avatar Feb 05 '18 23:02 jer-tx

For me, on ubuntu 16.04, with 3.0.5, putting the code in ssb-interop.js works.

It's still not nice if I am signed into 2 accounts, but that's another issue

vladiibine avatar Feb 19 '18 16:02 vladiibine

I can confirm this as well

Azzuen1 avatar Mar 04 '18 20:03 Azzuen1

Dark theme is working ok but text on attachments is black and not readible, any idea how to fix that?

antok87 avatar Mar 05 '18 07:03 antok87

Has anyone managed to create a fix for this theme that brings back full css control (text colors) and corrects sidebar overlap issues ("jump to" search overlaying "All Unreads" link)?

Currently using slack 3.1.0 beta desktop app on Windows 10. The update from @david1602 referenced above brings back functionality, but the text is stuck on grey and doesn't respect any font color choices.

Bterrell721 avatar Mar 07 '18 16:03 Bterrell721

I guess the CSS attributes and classes have changed a bit on the actual web app. You will need to apply new class overrides for things that you would like. For example to apply changes to the body text you will need new custom CSS in index.js.

div.c-message__content { color:#fff !important; } div.c-message__content span.c-message__body { color:#fff !important; } div.c-message__content div.c-message__content_header { color:#fff !important; } div.c-message__content div.c-message__content_header span.c-message__sender a.c-message__sender_link { color:#fff !important; } div.c-message__content div.c-message__content_header a.c-timestamp { color:#fff !important; } div.c-message__content div.c-message__content_header a.c-timestamp span.c-timestamp__label { color:#fff !important; }

Adding the above will make all the body text white. You can find out new classes or other classes you might need by going to the web app in your browser, right clicking what you want, inspecting source, then adding a CSS override as above.

brantleyr avatar Mar 07 '18 20:03 brantleyr

Seems to be a duplicate of: https://github.com/widget-/slack-black-theme/issues/39

brantleyr avatar Mar 07 '18 20:03 brantleyr

I am using slack on KDE. I applied this hack, It ain't working.

bnayagrawal avatar Apr 16 '18 07:04 bnayagrawal

@bnayagrawal Confirmed that the updated changes to slack have broken this modification (applying changes to either index.js or ssb-interop.js still ends up w/ the chat background being white on white text).

seanpianka avatar Apr 16 '18 23:04 seanpianka

@seanpianka Also confirming that as well on my end with 3.1.1

jrausch12 avatar Apr 17 '18 00:04 jrausch12

@seanpianka and @jrausch12 this is because new CSS elements have been introduced that also need to be colored. The code you are adding to these files is not updated appropriately.The most recent comment on this issue addresses the problem.

Alternatively, I've been trying to keep this fork up-to-date with the latest fixes. It also addresses some other stylistic nuances that I haven't seen others address yet. Here it is: https://github.com/d-fay/slack-black-theme#installing-into-slack

d-fay avatar Apr 18 '18 00:04 d-fay