Check for invalid combination before calling DefaultAI::expedition_management()

[bunnybot]

Mirrored from Codeberg Created on Thu Apr 25 00:20:42 CEST 2024 by Tóth András (tothxa)

---

Type of change Bugfix

Issue(s) closed Fixes #6436

New behavior DefaultAI::expedition_management() is only called if ship is really an expedition, otherwise the ShipObserver's waiting_for_command_ is cleared.

Possible regressions none?

[bunnybot]

Assigned to tothxa

[bunnybot]

Mirrored from Codeberg On Sat Apr 27 16:02:42 CEST 2024, frankystone wrote:

---

Since this might be problematic in every game vs an ai player, shouldn't this be a release fix (v1.2-rc2)?

[bunnybot]

Mirrored from Codeberg On Wed May 01 10:49:22 CEST 2024, Stephan Lutz (hessenfarmer) wrote:

---

Since this might be problematic in every game vs an ai player, shouldn't this be a release fix (v1.2-rc2)?

+1 from my side. As we got quite some reports after the release reporting crashes and segfaults and other bugs shall we plan for a small bugfix intermediate release before going to the 1.3? <@>Nordfriese what do you think?

[bunnybot]

Mirrored from Codeberg On Wed May 01 11:04:02 CEST 2024, Benedikt Straub (Nordfriese) wrote:

---

+1 from me too.

If we publish a bugfix point release I'd also like to include all the other recent smallish bugfixes as well, namely:

• c51189f67aa06b2273486134473f17c7a014ace8 (Skip invalid map files in editor Load/Save map window)
• b0c4c025befe3c3c09226b52cdd5d41446ffe16b (Fix memory leaks in main menu Watch Last Replay)
• b166b0b52a7da5dc88c74b079149cc46e806de81 (Game setup: Unselect incompatible starting conditions when changing win condition)
• 1907f67c6978b4dc8717e0c84670727940eea80b (Fix soldier request for expedition ships)
• 1babc3aac05757ac25c6992da13afa6c41a6cec5 (Add thread identifier to crash reports)

Regardless of how many such fixes we backport I'm going to make that a one-week release candidate (1.2.1~rc1) followed by a point release 1.2.1.

[bunnybot]

Mirrored from Codeberg On Wed May 01 13:36:07 CEST 2024, Tóth András (tothxa) wrote:

---

The CI failure was transient, re-running the failed jobs succeeded, but apparently bunnybot can't handle that.

[bunnybot]

Mirrored from Codeberg On Wed May 01 13:53:14 CEST 2024, Benedikt Straub (Nordfriese) wrote:

---

<@>bunnybot merge force

[hessenfarmer]

Mirrored from Codeberg On Wed May 01 11:04:02 CEST 2024, Benedikt Straub (Nordfriese) wrote:

+1 from me too.

If we publish a bugfix point release I'd also like to include all the other recent smallish bugfixes as well, namely:

* [c51189f](https://github.com/widelands/widelands/commit/c51189f67aa06b2273486134473f17c7a014ace8) (Skip invalid map files in editor Load/Save map window)

* [b0c4c02](https://github.com/widelands/widelands/commit/b0c4c025befe3c3c09226b52cdd5d41446ffe16b) (Fix memory leaks in main menu Watch Last Replay)

* [b166b0b](https://github.com/widelands/widelands/commit/b166b0b52a7da5dc88c74b079149cc46e806de81) (Game setup: Unselect incompatible starting conditions when changing win condition)

* [1907f67](https://github.com/widelands/widelands/commit/1907f67c6978b4dc8717e0c84670727940eea80b) (Fix soldier request for expedition ships)

* [1babc3a](https://github.com/widelands/widelands/commit/1babc3aac05757ac25c6992da13afa6c41a6cec5) (Add thread identifier to crash reports)

Regardless of how many such fixes we backport I'm going to make that a one-week release candidate (1.2.1~rc1) followed by a point release 1.2.1.

including all recent fixes of crashes was indeed what I had in mind, while asking. But we should go over the list of recent bug reports and see what would be worth fixing as well. i.e. bugs that are deemed critical or really annoying. Furthermore I`d like to add the criterion that we should have a special look to bugs reported by users other then the dev team to show that it is worth it to sen bug reports. We might even thank the community for finding and especially reporting them.