Ship window improvements

[bunnybot]

Mirrored from Codeberg Created on Mon Jan 29 17:35:34 CET 2024 by Tóth András (tothxa)

---

Type of change Bugfix & New feature

Issue(s) closed Fixes #6330

New behavior

• only display SoldierPanel for warships that are ready to fight, show onboard wares display (possibly with soldiers as generic cargo) while refitting
• allow stopping expeditions where they are (like warships) when they are scouting, only show construct port button when active

Possible regressions Ship window, wares and workers handling while refitting and soldier capacity is set to 0

Additional context Expedition stopping is in separate commit(https://codeberg.org/tothxa/widelands/commit/f0a28f668bca391b572daed9857938a59e17994c), so it can be reverted easily if voted down. Otherwise icons should be more different probably. Either use scaled down portspace icon for construct port, or a smaller anchor in the stopping icon?

[bunnybot]

Assigned to tothxa