widelands icon indicating copy to clipboard operation
widelands copied to clipboard

Issues with Asiatic languages

Open SirVer opened this issue 2 years ago • 5 comments

This was reported to me via Email:

I am using a Windows 7 64-bit environment.

In my environment, errors occur when this game is set in Korean, Traditional Chinese, Simplified Chinese, and Japanese. 


Traditional Chinese translation rate: 0%.
Simplified Chinese translation rate: 23%.
Japanese translation rate: 67%.
Translation rate in Korean: 95% 

When I play the game, there are many parts that come out in English, but it doesn't work.


I think the problem is the module that handles CJK.


If a problem occurs even when the Korean translation is applied at 0%, I think the CJK processing part will be a problem.
(But I don't know how to do it)

I don't remember exactly, but I think this part has been a problem since 1.0.

SirVer avatar Jan 16 '22 08:01 SirVer

I can confirm this. If you select one of these languages the game gets stuck while loading the tribes immovables of the first player.

tried to catch something in gdb, but it kept writing:

"warning: invalid parameter passed to c runtime function"

hessenfarmer avatar Jan 16 '22 20:01 hessenfarmer

I can't reproduce any type of bug with japanese or chinese, it all seems to behave fine for me. Loading a game works normally, the strings are no different from any other partially complete language, and there are no console errors.

Perhaps a Windows-specific bug?

I'm not really sure what sort of problem the original bug report is describing though; "errors occur" and "there are many parts that come out in English, but it doesn't work" is a bit nondescript…

Noordfrees avatar Jan 16 '22 20:01 Noordfrees

well I believe it describes the problem I encountered on my system while trying to reproduce.

if you select one of the languages you can't start the game as the loading screen gets stuck at step 2/6 loading the tribes immovables of the first players tribe. even if you barely realize that you have selected the chinese language due to bein only 0.x % translated, meaning it does not depend on the strings itself probably. everything works in b21 but it doesn't in 1.0 and later.

possible reasons any change in handling these languages or any issue in addons. I already scanned the changelog but didn't see a smoking gun yet

hessenfarmer avatar Jan 17 '22 14:01 hessenfarmer

Here, also on linux, all is fine: Setting Japanese as language, restarting the game and create a new game.

Isn't it possible to add some log output to https://github.com/widelands/widelands/blob/dfdbd6a3c06d5c62e1f0690a29cfc1e16fa2f190/src/logic/map_objects/tribes/tribe_descr.cc#L413 or some other related functions?

Possibly related: #4978

frankystone avatar Jan 17 '22 15:01 frankystone

The original poster reached out to me via email again, which makes me think that the problem is maybe not in the translations, but somewhere related to a asian OS?

This bug hasn't been fixed yet.

I don't know if it's a Windows-only problem.
  
https://github.com/widelands/widelands/issues/5211 
 
Win 10 64bit

ko Korean
ka Georgian 
fa Persian
hi Hindi 
he Hebrew
zh_TW Chinese (Taiwan)
zh_CN Chinese (China)
ja Japanese

I found the same problem when executing in the above language as when executing in Korean.
I think there are probably more languages.

These are hardly translated.
I don't think this problem is a matter of translation.
When playing the game, I think that loading is not processing certain OS and specific languages correctly.

But I don't know where it is.
If you tell me how to build a development environment, I will test it.

SirVer avatar Jun 23 '22 20:06 SirVer