aws-ec2-ssh icon indicating copy to clipboard operation
aws-ec2-ssh copied to clipboard
verified publisher icon widdix

Added option to remove email domain from usernames - with support for pagination

Open maartenkamoen opened this issue 6 years ago • 4 comments

Based on: https://github.com/widdix/aws-ec2-ssh/pull/126

Added support for pagination when listing all users

maartenkamoen avatar Jul 08 '19 16:07 maartenkamoen

LGTM.

mvanbaak avatar Jul 09 '19 07:07 mvanbaak

@michaelwittig Is there anything stopping a merge of this PR ?

mvanbaak avatar Aug 13 '19 10:08 mvanbaak

my only concern is that we have no test for this... there was no need for testing pagination before and I don't see how this could be accomplished easily. Any ideas?

michaelwittig avatar Aug 14 '19 11:08 michaelwittig

How about adding a variable for the '--max-items' parameter and setting it to 1 to test the pagination feature? This would negate the need for more than 50 users in the test account.

maartenkamoen avatar Nov 19 '19 07:11 maartenkamoen