aws-cf-templates icon indicating copy to clipboard operation
aws-cf-templates copied to clipboard

Published 20 hours ago • verified publisher icon widdix

Adds performance insights to Postgres template

Open O5m4r opened this issue 4 years ago • 3 comments

  • [x] yamllint state/rds-postgres.yaml
  • [x] cfn-lint -i E1019 E3002 E2520 -t state/rds-postgres.yaml
  • [x] aws cloudformation validate-template --template-body file://state/rds-postgres.yaml

Added parameters to optionally have performance insights in Postgres RDS, and custom amount of retention days in it.

O5m4r avatar Sep 11 '20 12:09 O5m4r

@andreaswittig could you check the defaults? Is it a good idea to enable by default or will this break existing setups with small instances? Not sure if we should get rid of PerformanceInsights and turn off if PerformanceInsightsRetentionPeriod is set to zero.

michaelwittig avatar Sep 11 '20 14:09 michaelwittig

@O5m4r Thanks a lot for your contribution.

Your solution is very flexible but comes with the disadvantage, that setting PerformanceInsight to true will fail for some instance types.

I took a different approach for the wordpress/wordpress-ha template. My idea was to enable RDS Performance Insights for all supported instance types out of the box. See https://github.com/widdix/aws-cf-templates/pull/490. What do you think?

andreaswittig avatar Sep 21 '20 12:09 andreaswittig

I like the Idea of having a mapping, to make sure we don't allow Performance Insights in an Instance that doesn't support it.

O5m4r avatar Sep 23 '20 08:09 O5m4r