core
core copied to clipboard
wicketstuff
Is class WicketChildListSerializer really needed?
Hi,
If I remove class
https://github.com/wicketstuff/core/blob/master/jdk-1.6-parent/serializer-kryo2/src/main/java/org/wicketstuff/pageserializer/kryo/WicketChildListSerializer.java
Test seems to pass and my application seem to work the same. Looking at the source code of Kryo it is not clear why this is need (private inner classes should works). Does anyone knows why this class is "needed"?
Regards,
Ernesto
It has been needed when I first played with Kryo. I think I've borrowed it from Magro's kryo-serializers project.
Maybe it is no more needed with the new Kryo version. If you can (de)serialize a page with at least several components without this serializer then you can drop it.
Ping @michaelmosmann .
Martin,
Tanks for your answer. I'm still not sure if this class is needed or not. The parts of hour applications than I can test seem to work without it.
On the other hand we are having problems with certain nested classes that Kryo is not able to deserialize (see https://groups.google.com/forum/?fromgroups=#!topic/kryo-users/UxF7X7PTt-U). It seems Kryo is "swallowing" InvocationTargetException that cause it. This happens on parts of the application I don't have full access to. So the only thing I'm able to get are the stack traces and the code of failing classes. But the failing cases look similar to the problem WicketChildListSerializer.java seems to be solving
Today i have got some exceptions while deserializing. I will write some more tests to get such cases and make sure, that anything will work... (btw: It's not merged to master or core-1.5.x so dont expect changes there.)
