myshoes icon indicating copy to clipboard operation
myshoes copied to clipboard

Populate labels in the generated script.

Open alfred-stokespace opened this issue 1 year ago • 2 comments

As mentioned https://github.com/whywaita/shoes-aws/pull/2#issuecomment-2093526663 in sister PR https://github.com/whywaita/shoes-aws/pull/2

now that I'm doing full integration testing, it is clear that the script needs the labels from GH otherwise jobs won't schedule.

alfred-stokespace avatar May 03 '24 21:05 alfred-stokespace

@alfred-stokespace Sorry, my response is late.

Your suggestion is not bad. But it has a problem of security. I’m afraid of any code execution. So, Could you add an option that “is populate labels”? myshoes will populate labels if true.

whywaita avatar Jun 06 '24 14:06 whywaita

@alfred-stokespace Sorry, my response is late.

Your suggestion is not bad. But it has a problem of security. I’m afraid of any code execution. So, Could you add an option that “is populate labels”? myshoes will populate labels if true.

Good point! @whywaita I should have considered that. Thanks.

alfred-stokespace avatar Jun 06 '24 21:06 alfred-stokespace