whylogs icon indicating copy to clipboard operation
whylogs copied to clipboard

Java IntegralMetric and Components

Open TheMellyBee opened this issue 2 years ago • 2 comments

Description

Part of the longer effort to port v1 to Java. This iteration is a chunk of code that involves the Metric, Integral Metric and supporting classes along with their tests.

This allows for Integral Metrics to be created from their metric components, update from a column of mixed data types.

Biggest arch area to take note of is the Metric, Base Metric and Integral Metric. This allows us to have Metrics in collections, but still maintain the typing of the subclass throughout. It makes it clearer for user and writer of the metrics what their type is and what can be combined with what at anyone time.

Notes:

  • no registries, serializers, deserializers, to/from protobuf
  • Lots of TODOs just to not forget section for the next iteration (which is the registry)
  • Types are very rough and will be iterated on as the registry and resolvers are done <- direct pull from python right now which isn't going to be the final version

Related

  • [X] I have reviewed the Guidelines for Contributing and the Code of Conduct.

TheMellyBee avatar Aug 02 '22 01:08 TheMellyBee

This chunk is ready for review. :) Please check my notes above for the two places I'd really like an extra look/question.

TheMellyBee avatar Aug 04 '22 22:08 TheMellyBee