whylogs icon indicating copy to clipboard operation
whylogs copied to clipboard

Support creating a ColumnProfile from ColumnProfileView

Open andyndang opened this issue 2 years ago • 3 comments

Description

Ramandeep Singh

Regarding the latest i.e. whylogs v1 API changes. We moved from just having ColumnProfile to ColumnProfile->ColumnProfileView for serializing/deserializing and this is unidirectional. This leads to the following two issues. Now you can't update a serialized profile because you'd have to create another ColumnProfile and call merge on its view with the previous view. This is still doable. You'd lose the type information, since that is stored in Schema for the resolver, present in ColumnProfile, so you can't autogenerate tests on collected profile based on data type, since you don't know the data type.

Suggestions

If we can somehow access the same Schema object, in theory users can rehydrate the ColumnProfile from a View - this probably a sensible feature request (this assumes that users will pass in the correct config + schema etc…)

Idea: pass in the schema/config to the param. Assuming the configs are the same that should be an equivalent of roundtrip serialization. This way we don't have to deal with storing the config, but still enable roundtrip serder for certain users

view = ColumnProfileView.read(...)
column_profile=view.to_profile(schema=schema)

Related

  • https://rsqrd-ai.slack.com/archives/C01BMDKKBMZ/p1656528717113839

  • [x] I have reviewed the Guidelines for Contributing and the Code of Conduct.

andyndang avatar Jun 29 '22 21:06 andyndang

This issue is stale. Remove stale label or it will be closed tomorrow.

github-actions[bot] avatar Aug 01 '22 13:08 github-actions[bot]

Still relevant

jamie256 avatar Aug 08 '22 15:08 jamie256

This issue is stale. Remove stale label or it will be closed tomorrow.

github-actions[bot] avatar Sep 12 '22 13:09 github-actions[bot]

This issue is stale. Remove stale label or it will be closed tomorrow.

github-actions[bot] avatar Oct 24 '22 13:10 github-actions[bot]

This issue is stale. Remove stale label or it will be closed tomorrow.

github-actions[bot] avatar Nov 28 '22 13:11 github-actions[bot]

This issue is stale. Remove stale label or it will be closed tomorrow.

github-actions[bot] avatar Jan 02 '23 13:01 github-actions[bot]

This issue is stale. Remove stale label or it will be closed tomorrow.

github-actions[bot] avatar Feb 06 '23 13:02 github-actions[bot]