Video-Hub-App icon indicating copy to clipboard operation
Video-Hub-App copied to clipboard

Issue #841: button groups in 'settings-buttons.ts'

Open lyss0306 opened this issue 1 year ago • 2 comments

Solution to issue #841 Removed 'showFreq', 'showRelatedVideosTray', 'showRecentlyPlayed', 'showDetailsTray' from group 6 Added 'showFreq', 'showRelatedVideosTray', 'showRecentlyPlayed', 'showDetailsTray' to group 14 (settings tab 3)

lyss0306 avatar Sep 13 '24 05:09 lyss0306

@lyss0306 thank you for the PR 🙇‍♂️ I'm hoping to get to reviewing all PRs and merging them in this winter 😅 (still trying to finish my DIY kitchen work in the house -- so many projects, so little time!)

Thank you for your patience ♥

whyboris avatar Sep 13 '24 15:09 whyboris

@lyss0306 - when I click on Files changed I'm surprised to see an addition of a new file without changes to a previous file. Perhaps you've accidentally added the file rather than replacing the already-present settings-buttons.ts ? Could you move this file to the location of the current one: src/app/common/settings-buttons.ts replacing the old one - this way it will be easy to see what lines of code changed 👍😁👍

whyboris avatar Sep 13 '24 15:09 whyboris