Video-Hub-App icon indicating copy to clipboard operation
Video-Hub-App copied to clipboard

Add optional password to hub

Open whyboris opened this issue 1 year ago • 8 comments

⚠️ this would not be "super secure" but simply to prevent snooping by someone.

  • Add "password" key to FinalObject https://github.com/whyboris/Video-Hub-App/blob/main/interfaces/final-object.interface.ts#L17
  • Any hub that is opened that has a password will have a popup overlay (modal) where a user needs to enter a password
    • incorrect password entry just clears the password
    • it's probably simplest to not let any interactions happen besides minimizing / closing the app 🤔

People over the years requested this 🤷‍♂️ seems easy to implement 😅

note: this means opening the .vha2 file one can easily read the password 👌 ... though to make it more secure we can (salt and then) hash the password and check the hash 🥳

whyboris avatar Jan 30 '24 03:01 whyboris

I'm open to the discussion:

Should the (optional!) password be for the app or per hub?

whyboris avatar Jan 30 '24 03:01 whyboris

Can I work on this issue?

minazaher avatar Jun 23 '24 09:06 minazaher

Hey @minazaher thank you for the offer! Please give this a go 🤝

Please let me know if you have any questions along the way - I'm happy to assist 😁

For the user to add / remove / change the password - let's put the UI in the 4th tab in settings ("Current hub")

whyboris avatar Jun 23 '24 18:06 whyboris