Video-Hub-App icon indicating copy to clipboard operation
Video-Hub-App copied to clipboard
verified publisher icon whyboris

feat(settings): tabs scrolls to top if navigated

Open dVp007 opened this issue 4 years ago • 4 comments

solving! Scroll to top when switching settings tabs #681

dVp007 avatar Sep 13 '21 05:09 dVp007

Thank you very much! The code looks like it will work 💯 -- I just want to test it out before merging 🤝

whyboris avatar Sep 13 '21 13:09 whyboris

Okay will check it before can you send me a video or a GIF so that I can figure out what is wrong. Because when I tried it was scrolled at the top.

dVp007 avatar Sep 19 '21 17:09 dVp007

To replicate: 1 scroll down to bottom, now click on the 1st tab: 2 notice the scrollbar is not at the top. On your branch the scrollbar seems to move up a bit, but not to the top of the tab. Perhaps the behavior is a bit different if the app is opened 100% on a very large screen, but it doesn't seem to work on my end as expected. @dVp007 🤝

whyboris avatar Sep 21 '21 18:09 whyboris

Can you please check i actually forgot to commit changes of a file. I guess it should work now.

dVp007 avatar Sep 23 '21 14:09 dVp007

Sorry -- when I checked it before releasing version 3.2.0 it didn't seem to work on my machine 😓

Thank you for your attempted contribution 🙇

whyboris avatar Apr 03 '23 12:04 whyboris