Clean up (click) emits

[whyboris]

There's RightClickEmit, VideoClickEmit, and many others that are not strongly typed 😓

It's messy code figuring out which (click) event is happening and what is being sent via new EventEmitter from components to their parents 🙄

My todo 😅

[altynbeq]

Hi, do you still need help with it ?

[whyboris]

I'm happy to take the help if you're offering 😉

The challenge is I have components nested inside components that emit data that needs to be passed through.

Currently everything works on master so it's no problem, but it's really convoluted at times, and I suspect there's a way to make it all uniform.

If you decide to give this a go, please let me know if you have any questions and feel free to reach out for assistance 🤝

Cheers!

[whyboris]

Hey @altynbeq -- please let me know if you're still interested in trying out this issue 👍

I didn't add a good first issue tag because I'm unsure if it's "newbie friendly" 😅

No matter who decides to work on it I'm very happy to help along 🤝

[whyboris]

Pushing it off until after 3.0.0 release: everything is working, no bugs as far as I can tell. The fix is internal and not required prior to 3.0.0 👌

[whyboris]

To reiterate: everything is working, there are no problems for the users. I just suspect the code could be cleaner 🤷

This is a very low-priority issue 👌

[whyboris]

This should be easier now that tsconfig.json has this:

{
  "angularCompilerOptions": {
    "strictTemplates": true
  }
}

This will error out when you run npm run electron and list all the errors (and VS Code will also underline the errors in templates).

Currently there are about 20 of them -- all complaining about mismatched type :trollface:

Argument of type 'object' is not assignable to parameter of type 'VideoClickEmit'. Property 'mouseEvent' is missing in type '{}' but required in type 'VideoClickEmit'