Video-Hub-App icon indicating copy to clipboard operation
Video-Hub-App copied to clipboard

Application Icon

Open mcpalmer1980 opened this issue 6 years ago • 7 comments

I never tried this program in Windows, but in Linux there is no application icon. This leaves a blank space in my dash panel, making it look like I'm hiding something! Considering how nice the toolbar icons look, this surprises me.

Is there a reason for this? Can you tell me how to add my own icon? Would you like me to make one for your review?

I'm thinking of something like a car's wheel(hub) or a gear with a play symbol in the middle. I possess considerable experience and a hint of skill with vector graphics and icon design.

mcpalmer1980 avatar Nov 22 '19 14:11 mcpalmer1980

I was in a rush to release the Linux version (as the other two have been thoroughly tested), and I didn't have a Linux box for a while (until I realized I could build it in a VM on my Mac).

If someone knows how to add an icon during the build, please do it 🙇

The build system for Linux changed a bit since Electron-Builder got updated, so the previously-working config got busted a bit 🤷‍♂

whyboris avatar Nov 27 '19 00:11 whyboris

I strongly think the icon should simply be the same one the Windows and Mac have: https://github.com/whyboris/Video-Hub-App/blob/master/src/favicon.png

whyboris avatar Nov 27 '19 00:11 whyboris

I can confirm this issue.

I tried many "solutions" for this issue around the internet, but none seems to work for me

frez777 avatar Jan 25 '20 11:01 frez777

This issue persists on the Gnome desktop, but the icon shows fine in KDE. I haven't tried other desktop environments.

mcpalmer1980 avatar May 19 '20 18:05 mcpalmer1980

just confirming if anyone fixed this yet?

jamesg-the-dev avatar May 13 '24 11:05 jamesg-the-dev

I've not worked on it and I don't think anyone added a PR for it either. I do not think this issue has been fixed 😓 though I've not tried reproducing it -- perhaps the issue is OS related 🤔

whyboris avatar May 13 '24 17:05 whyboris

oh cool, I'm going to investigate the issue and send through a PR

jamesg-the-dev avatar May 14 '24 10:05 jamesg-the-dev