jaxb-facets icon indicating copy to clipboard operation
jaxb-facets copied to clipboard

Pushing facets support upstream

Open schrepfler opened this issue 5 years ago • 5 comments

As we know up streaming of jaxb-facets didn't happen even though we went through the procedure couple of times. That said, with the JDK going through simplification and splitting up of JEE to Jakarta and moving under the eclipse umbrella perhaps there's some headroom to try again? The repository is here https://github.com/eclipse-ee4j/jaxb-ri, shall we give it another go?

schrepfler avatar Sep 11 '20 15:09 schrepfler

Hi, one thing we check is license compatibility. Do we need the authors to publish their contribution under a different license or sign an additional contribution agreement?

vbence avatar Sep 12 '20 14:09 vbence

I suppose signing additional agreements is a must even though I seem to recall the guys already did it once or twice but it was under a different organization then. License is also interesting question, the repo seems to have copied the original CDDL license from glassfish while the one in jaxb-ri is Oracle copyright, not sure I understand how that works if it’s under Eclipse foundation now. I’m sure the guys can clarify everything once we have the pull request ready though.

Srdan

On Sat, 12 Sep 2020 at 16:44, Varga Bence [email protected] wrote:

Hi, one thing we check is license compatibility. Do we need the authors to publish their contribution under a different license or sign an additional contribution agreement?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/whummer/jaxb-facets/issues/39#issuecomment-691500523, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA3YIZVILIMFWEUVOZLE3SFOCM7ANCNFSM4RHXJIUQ .

schrepfler avatar Sep 12 '20 15:09 schrepfler

Hi @whummer any chance we can get this over the finish line if you're still active?

schrepfler avatar Dec 09 '20 20:12 schrepfler

Hi @schrepfler - thanks for your message. This repo hasn't been maintained in a while, and I'm not sure if I'll have the capacity to actively push it upstream. But please feel free to take the code, modify it in any way (as necessary), and contribute it upstream - if you could make this happen, that would be much appreciated! If there's anything particular I can help out with (e.g., changing the license type, etc), then please let me know or raise a PR directly against this repo (I'll be happy to merge right away). Thanks for your support in pushing this through! Cheers

whummer avatar Dec 10 '20 14:12 whummer

I think the main problem is that there's no common ancestor with the https://github.com/eclipse-ee4j/jaxb-ri repository which also has some structural differences compared to this version. I think ideally this would be a full PR against that repo but I don't think it should be submitted by anyone else but you @whummer or @pellcorp which I think are the main authors of the library (correct me if I'm wrong).

schrepfler avatar Dec 11 '20 15:12 schrepfler